Context Navigation

Changeset 148244 in webkit

Timestamp:

Apr 11, 2013 4:25:50 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

TextTrackList's .onremovetrack is missing from IDL
https://bugs.webkit.org/show_bug.cgi?id=103421

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html

(TextTrackList::remove):
(TextTrackList::scheduleRemoveTrackEvent):

(TextTrackList):

LayoutTests:

Location:

trunk

Files:

-                      r148236
+                      r148244
+-04-11  Brendan Long  <b.long@cablelabs.com>
+        TextTrackList's .onremovetrack is missing from IDL
+        https://bugs.webkit.org/show_bug.cgi?id=103421
+        Reviewed by Eric Carlson.
+        * media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Added.
 -04-11  Sukolsak Sakshuwong  <sukolsak@gmail.com>

-                      r148242
+                      r148244
+-04-11  Brendan Long  <b.long@cablelabs.com>
+        TextTrackList's .onremovetrack is missing from IDL
+        https://bugs.webkit.org/show_bug.cgi?id=103421
+        Reviewed by Eric Carlson.
+        Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html
+        * html/track/TextTrackList.cpp:
+        (TextTrackList::remove):
+        (TextTrackList::scheduleRemoveTrackEvent):
+        * html/track/TextTrackList.h:
+        (TextTrackList):
+        * html/track/TextTrackList.idl:
 -04-11  Alberto Garcia  <agarcia@igalia.com>

-                      r148050
+                      r148244
     track->setMediaElement(0);
+    RefPtr<TextTrack> trackRef = (*tracks)[index];
     tracks->remove(index);
+    scheduleRemoveTrackEvent(trackRef.release());
+}
 …
+}
+void TextTrackList::scheduleRemoveTrackEvent(PassRefPtr<TextTrack> track)
+{
+    // 4.8.10.12.3 Sourcing out-of-band text tracks
+    // When a track element's parent element changes and the old parent was a
+    // media element, then the user agent must remove the track element's
+    // corresponding text track from the media element's list of text tracks,
+    // and then queue a task to fire a trusted event with the name removetrack,
+    // that does not bubble and is not cancelable, and that uses the TrackEvent
+    // interface, with the track attribute initialized to the text track's
+    // TextTrack object, at the media element's textTracks attribute's
+    // TextTrackList object.
+    RefPtr<TrackBase> trackRef = track;
+    TrackEventInit initializer;
+    initializer.track = trackRef;
+    initializer.bubbles = false;
+    initializer.cancelable = false;
+    m_pendingEvents.append(TrackEvent::create(eventNames().removetrackEvent, initializer));
+    if (!m_pendingEventTimer.isActive())
+        m_pendingEventTimer.startOneShot(0);
+}
 void TextTrackList::asyncEventTimerFired(Timer<TextTrackList>*)
+{

-                      r146380
+                      r148244
     DEFINE_ATTRIBUTE_EVENT_LISTENER(addtrack);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(removetrack);
     void clearOwner() { m_owner = 0; }
 …
     void scheduleAddTrackEvent(PassRefPtr<TextTrack>);
+    void scheduleRemoveTrackEvent(PassRefPtr<TextTrack>);
     void asyncEventTimerFired(Timer<TextTrackList>*);

r131172	r148244
37	37
38	38	attribute EventListener onaddtrack;
	39	attribute EventListener onremovetrack;
39	40
40	41	void addEventListener(in DOMString type,

Note: See TracChangeset for help on using the changeset viewer.