Changeset 148258 in webkit

Timestamp:

Apr 11, 2013 7:38:32 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Selection gaps don't repaint correctly with transforms
​https://bugs.webkit.org/show_bug.cgi?id=111000

Patch by Shezan Baig <Shezan Baig> on 2013-04-11
Reviewed by Simon Fraser.

Source/WebCore:

When computing offsetFromRepaintContainer, we need to add UseTransforms
to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
the default value for the flag, so this change effectively only adds
the UseTransforms flag.

Tests: fast/repaint/selection-gap-absolute-child.html

fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):

LayoutTests:

• fast/repaint/selection-gap-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-absolute-child.html: Added.
• fast/repaint/selection-gap-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-fixed-child.html: Added.
• fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-flipped-absolute-child.html: Added.
• fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-flipped-fixed-child.html: Added.
• fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-transformed-absolute-child.html: Added.
• fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-transformed-fixed-child.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/selection-gap-absolute-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-absolute-child.html (added)
• LayoutTests/fast/repaint/selection-gap-fixed-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-fixed-child.html (added)
• LayoutTests/fast/repaint/selection-gap-flipped-absolute-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-flipped-absolute-child.html (added)
• LayoutTests/fast/repaint/selection-gap-flipped-fixed-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-flipped-fixed-child.html (added)
• LayoutTests/fast/repaint/selection-gap-transformed-absolute-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-transformed-absolute-child.html (added)
• LayoutTests/fast/repaint/selection-gap-transformed-fixed-child-expected.txt (added)
• LayoutTests/fast/repaint/selection-gap-transformed-fixed-child.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-11  Shezan Baig  <sbaig1@bloomberg.net>
+
+        Selection gaps don't repaint correctly with transforms
+        https://bugs.webkit.org/show_bug.cgi?id=111000
+
+        Reviewed by Simon Fraser.
+
+        * fast/repaint/selection-gap-absolute-child-expected.txt: Added.
+        * fast/repaint/selection-gap-absolute-child.html: Added.
+        * fast/repaint/selection-gap-fixed-child-expected.txt: Added.
+        * fast/repaint/selection-gap-fixed-child.html: Added.
+        * fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
+        * fast/repaint/selection-gap-flipped-absolute-child.html: Added.
+        * fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
+        * fast/repaint/selection-gap-flipped-fixed-child.html: Added.
+        * fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
+        * fast/repaint/selection-gap-transformed-absolute-child.html: Added.
+        * fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
+        * fast/repaint/selection-gap-transformed-fixed-child.html: Added.
+
 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-11  Shezan Baig  <sbaig1@bloomberg.net>
+
+        Selection gaps don't repaint correctly with transforms
+        https://bugs.webkit.org/show_bug.cgi?id=111000
+
+        Reviewed by Simon Fraser.
+
+        When computing offsetFromRepaintContainer, we need to add UseTransforms
+        to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
+        the default value for the flag, so this change effectively only adds
+        the UseTransforms flag.
+
+        Tests: fast/repaint/selection-gap-absolute-child.html
+               fast/repaint/selection-gap-fixed-child.html
+               fast/repaint/selection-gap-flipped-absolute-child.html
+               fast/repaint/selection-gap-flipped-fixed-child.html
+               fast/repaint/selection-gap-transformed-absolute-child.html
+               fast/repaint/selection-gap-transformed-fixed-child.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::selectionGapRectsForRepaint):
+
 2013-04-11  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -3393 +3393 @@
         return GapRects();
 
-    // FIXME: this is broken with transforms
     TransformState transformState(TransformState::ApplyTransformDirection, FloatPoint());
-    mapLocalToContainer(repaintContainer, transformState);
+    mapLocalToContainer(repaintContainer, transformState, ApplyContainerFlip | UseTransforms);
     LayoutPoint offsetFromRepaintContainer = roundedLayoutPoint(transformState.mappedPoint());