Changeset 148273 in webkit

Timestamp:

Apr 12, 2013 3:54:21 AM (11 years ago)

Author:

jocelyn.turcotte@digia.com

Message:

Apply our MSVC 2012 optimizer bug workaround to all minor releases
​https://bugs.webkit.org/show_bug.cgi?id=114436

Reviewed by Alexey Proskuryakov.

The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.

• platform/text/TextEncodingRegistry.cpp:

(WebCore::TextEncodingNameHash::equal):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/TextEncodingRegistry.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-12  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
+
+        Apply our MSVC 2012 optimizer bug workaround to all minor releases
+        https://bugs.webkit.org/show_bug.cgi?id=114436
+
+        Reviewed by Alexey Proskuryakov.
+
+        The bug has only been partially fixed in Update 2 but our Update 1 workaround
+        still avoids the crash.
+
+        * platform/text/TextEncodingRegistry.cpp:
+        (WebCore::TextEncodingNameHash::equal):
+
 2013-04-12  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp

@@ -66 +66 @@
         char c2;
         do {
-#if defined(_MSC_FULL_VER) && _MSC_FULL_VER == 170051106
-            // Workaround for a bug in the VS2012 Update 1 optimizer, remove once the fix is released.
-            // https://connect.microsoft.com/VisualStudio/feedback/details/777533/vs2012-c-optimizing-bug-when-using-inline-and-char-return-type-x86-target-only
+#if defined(_MSC_VER) && _MSC_VER == 1700
+            // Workaround for a bug in the VS2012 Update1 and Update2 optimizer, remove once the fix is released.
+            // https://connect.microsoft.com/VisualStudio/feedback/details/781189/vs2012-update-ctp4-c-optimizing-bug
             c1 = toASCIILower(*s1++);
             c2 = toASCIILower(*s2++);