Changeset 148282 in webkit
- Timestamp:
- Apr 12, 2013 9:52:38 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 6 deleted
- 26 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r148268 r148282 1 2013-04-12 Ryosuke Niwa <rniwa@webkit.org> 2 3 [Mac] Enable spellchecking tests added in r141471 4 https://bugs.webkit.org/show_bug.cgi?id=108525 5 6 Reviewed by Darin Adler. 7 8 Updated the tests not to assume spelling correction suggestions were listed in a context menu since 9 only Chromium port did this. 10 11 * editing/spelling/resources/util.js: 12 (initSpellTest): Disable automatic text replacements. 13 14 * editing/spelling/spelling-with-underscore-selection-expected.txt: Removed. 15 * editing/spelling/spelling-with-underscore-selection.html: Removed. 16 17 This test erroneously assumed a specific word breaking behavior that doesn't include the underscore 18 when selecting a word especially since Chromium was the only port that was running these tests. 19 20 * editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed. 21 * editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed. 22 23 Ditto. 24 25 * editing/spelling/spelling-should-select-single-word-expected.txt: Removed. 26 * editing/spelling/spelling-should-select-single-word.html: Removed. 27 28 Removed since this test doesn't do anything useful without the assertion for the context menu. 29 30 * editing/spelling/spelling-double-clicked-word-expected.txt: 31 * editing/spelling/spelling-double-clicked-word.html: 32 * editing/spelling/spelling-exactly-selected-word-expected.txt: 33 * editing/spelling/spelling-exactly-selected-word.html: 34 * editing/spelling/spelling-with-punctuation-selection-expected.txt: 35 * editing/spelling/spelling-with-punctuation-selection.html: 36 * editing/spelling/spelling-with-whitespace-selection-expected.txt: 37 * editing/spelling/spelling-with-whitespace-selection.html: 38 39 * platform/efl/TestExpectations: 40 * platform/gtk/TestExpectations: 41 * platform/mac/TestExpectations: 42 * platform/qt/TestExpectations: 43 * platform/win/TestExpectations: 44 * platform/wincairo/TestExpectations: 45 * platform/wk2/TestExpectations: 46 1 47 2013-04-12 Zoltan Arvai <zarvai@inf.u-szeged.hu> 2 48 -
trunk/LayoutTests/editing/spelling/resources/util.js
r145940 r148282 27 27 testFunctionCallback = testFunction; 28 28 jsTestIsAsync = true; 29 30 internals.setAutomaticSpellingCorrectionEnabled(false); 31 29 32 internals.settings.setAsynchronousSpellCheckingEnabled(true); 30 33 internals.settings.setSmartInsertDeleteEnabled(true); … … 32 35 internals.settings.setUnifiedTextCheckerEnabled(true); 33 36 internals.settings.setEditingBehavior("win"); 37 34 38 var destination = document.getElementById(testElementId); 35 39 destination.focus(); -
trunk/LayoutTests/editing/spelling/spelling-double-clicked-word-expected.txt
r141354 r148282 9 9 PASS spellingMarkerRange.toString() is "wellcome" 10 10 PASS window.getSelection().toString() is "wellcome" 11 PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"12 11 PASS window.getSelection().toString() is "" 13 12 PASS window.getSelection().toString() is "wellcome " 14 13 PASS spellingMarkerRange.toString() is "wellcome" 15 14 PASS window.getSelection().toString() is "wellcome " 16 PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"17 15 PASS successfullyParsed is true 18 16 -
trunk/LayoutTests/editing/spelling/spelling-double-clicked-word.html
r145849 r148282 45 45 shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome"); 46 46 shouldBeEqualToString("window.getSelection().toString()", "wellcome"); 47 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");48 47 49 48 window.getSelection().removeAllRanges(); … … 73 72 shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome"); 74 73 shouldBeEqualToString("window.getSelection().toString()", "wellcome "); 75 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");76 74 }); 77 75 -
trunk/LayoutTests/editing/spelling/spelling-exactly-selected-word-expected.txt
r141354 r148282 9 9 PASS spellingMarkerRange.toString() is "wellcome" 10 10 PASS window.getSelection().toString() is "wellcome" 11 PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"12 11 PASS window.getSelection().toString() is "home" 13 12 PASS window.getSelection().toString() is "home" 14 PASS contextMenuElements[contextMenuElements.length - 1] is "<separator>"15 13 PASS successfullyParsed is true 16 14 -
trunk/LayoutTests/editing/spelling/spelling-exactly-selected-word.html
r141354 r148282 34 34 var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2; 35 35 eventSender.mouseMoveTo(x, y); 36 contextMenuElements = eventSender.contextClick();37 36 // Esc key to hide the context menu. 38 37 eventSender.keyDown(String.fromCharCode(0x001B), null); … … 41 40 shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome"); 42 41 shouldBeEqualToString("window.getSelection().toString()", "wellcome"); 43 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");44 42 45 43 // Select a correctly spelled word without surrounding whitespace or punctuation. … … 54 52 var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2; 55 53 eventSender.mouseMoveTo(x, y); 56 contextMenuElements = eventSender.contextClick();57 54 // Esc key to hide the context menu. 58 55 eventSender.keyDown(String.fromCharCode(0x001B), null); 59 56 60 57 shouldBeEqualToString("window.getSelection().toString()", "home"); 61 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "<separator>");62 58 }); 63 59 -
trunk/LayoutTests/editing/spelling/spelling-with-punctuation-selection-expected.txt
r141354 r148282 9 9 PASS spellingMarkerRange.toString() is "wellcome" 10 10 PASS window.getSelection().toString() is "wellcome!" 11 PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"12 11 PASS successfullyParsed is true 13 12 -
trunk/LayoutTests/editing/spelling/spelling-with-punctuation-selection.html
r141354 r148282 34 34 var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2; 35 35 eventSender.mouseMoveTo(x, y); 36 contextMenuElements = eventSender.contextClick();37 36 // Esc key to hide the context menu. 38 37 eventSender.keyDown(String.fromCharCode(0x001B), null); … … 41 40 shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome"); 42 41 shouldBeEqualToString("window.getSelection().toString()", "wellcome!"); 43 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");44 42 }); 45 43 -
trunk/LayoutTests/editing/spelling/spelling-with-whitespace-selection-expected.txt
r141354 r148282 8 8 PASS spellingMarkerRange.toString() is "wellcome" 9 9 PASS window.getSelection().toString() is " wellcome " 10 PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"11 10 PASS successfullyParsed is true 12 11 -
trunk/LayoutTests/editing/spelling/spelling-with-whitespace-selection.html
r141354 r148282 33 33 var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2; 34 34 eventSender.mouseMoveTo(x, y); 35 contextMenuElements = eventSender.contextClick();36 35 // Esc key to hide the context menu. 37 36 eventSender.keyDown(String.fromCharCode(0x001B), null); … … 40 39 shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome"); 41 40 shouldBeEqualToString("window.getSelection().toString()", " wellcome "); 42 shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");43 41 }); 44 42 -
trunk/LayoutTests/platform/efl/TestExpectations
r148076 r148282 1742 1742 # Spellchecker behavior tests. 1743 1743 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ] 1744 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]1745 1744 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 1746 1745 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ] 1747 1746 webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ] 1748 1747 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 1749 webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]1750 1748 webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ] 1751 1749 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ] 1752 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]1753 1750 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 1754 1751 -
trunk/LayoutTests/platform/gtk/TestExpectations
r148217 r148282 1311 1311 # Spellchecker behavior tests. 1312 1312 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ] 1313 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]1314 1313 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 1315 1314 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ] 1316 1315 webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ] 1317 1316 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 1318 webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]1319 1317 webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ] 1320 1318 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ] 1321 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]1322 1319 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 1323 1320 webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Failure ] -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r148255 r148282 166 166 167 167 # [WK2] [Mac] Spellcheck tests don't seem to work 168 webkit.org/b/105616 editing/spelling/spelling-changed-text.html 168 169 webkit.org/b/105616 platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html [ Failure ] 169 170 webkit.org/b/105616 platform/mac/editing/spelling/click-autocorrected-word.html -
trunk/LayoutTests/platform/mac/TestExpectations
r148115 r148282 1409 1409 webkit.org/b/94198 tables/mozilla/collapsing_borders/bug41262-3.html [ Failure ] 1410 1410 1411 # Spellchecker behavior tests. 1412 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ] 1413 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ] 1414 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 1415 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ] 1416 webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ] 1417 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 1418 webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ] 1419 webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ] 1420 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ] 1421 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ] 1422 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 1423 webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Skip ] 1411 webkit.org/b/114470 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 1412 webkit.org/b/114470 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 1424 1413 1425 1414 webkit.org/b/110027 compositing/transitions/transform-on-large-layer.html [ Pass ImageOnlyFailure ] -
trunk/LayoutTests/platform/qt/TestExpectations
r148268 r148282 821 821 # https://bugs.webkit.org/show_bug.cgi?id=108370 822 822 editing/spelling/spelling-double-clicked-word.html 823 editing/spelling/spelling-double-clicked-word-with-underscores.html824 823 editing/spelling/spelling-exactly-selected-multiple-words.html 825 824 editing/spelling/spelling-exactly-selected-word.html 826 825 editing/spelling/spelling-multiword-selection.html 827 826 editing/spelling/spelling-should-select-multiple-words.html 828 editing/spelling/spelling-should-select-single-word.html829 827 editing/spelling/spelling-subword-selection.html 830 828 editing/spelling/spelling-with-punctuation-selection.html 831 editing/spelling/spelling-with-underscore-selection.html832 829 editing/spelling/spelling-with-whitespace-selection.html 833 830 webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Failure ] -
trunk/LayoutTests/platform/win/TestExpectations
r148076 r148282 2656 2656 # Spellchecker behavior tests. 2657 2657 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ] 2658 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]2659 2658 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 2660 2659 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ] 2661 2660 webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ] 2662 2661 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 2663 webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]2664 2662 webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ] 2665 2663 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ] 2666 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]2667 2664 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 2668 2665 webkit.org/b/108370 editing/spelling/spellcheck-async-mutation.html [ Skip ] -
trunk/LayoutTests/platform/wincairo/TestExpectations
r147522 r148282 2988 2988 # Spellchecker behavior tests. 2989 2989 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ] 2990 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]2991 2990 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ] 2992 2991 webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ] 2993 2992 webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ] 2994 2993 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ] 2995 webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]2996 2994 webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ] 2997 2995 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ] 2998 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]2999 2996 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 3000 2997 -
trunk/LayoutTests/platform/wk2/TestExpectations
r148213 r148282 389 389 editing/spelling/spelling-attribute-change.html 390 390 editing/spelling/spelling-double-clicked-word.html 391 editing/spelling/spelling-double-clicked-word-with-underscores.html392 391 editing/spelling/spelling-exactly-selected-multiple-words.html 393 392 editing/spelling/spelling-exactly-selected-word.html … … 396 395 editing/spelling/spelling-multiword-selection.html 397 396 editing/spelling/spelling-should-select-multiple-words.html 398 editing/spelling/spelling-should-select-single-word.html399 397 editing/spelling/spelling-subword-selection.html 400 398 editing/spelling/spelling-with-punctuation-selection.html 401 editing/spelling/spelling-with-underscore-selection.html402 399 editing/spelling/spelling-with-whitespace-selection.html 403 400 platform/mac/editing/spelling/delete-into-misspelled-word.html -
trunk/Source/WebCore/ChangeLog
r148275 r148282 1 2013-04-12 Ryosuke Niwa <rniwa@webkit.org> 2 3 [Mac] Enable spellchecking tests added in r141471 4 https://bugs.webkit.org/show_bug.cgi?id=108525 5 6 Reviewed by Darin Adler. 7 8 Made automatic quote substitution, dash substitution, text replacement, and spelling correction 9 togglable via internals object. These functions are no-op when text replacement is not used. 10 11 This allows us to disable automatic spelling correction in spellcheck tests. 12 13 Enabled several tests added in r141471. 14 15 * WebCore.exp.in: 16 * testing/Internals.cpp: 17 (WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not 18 null whenever frame() is not null. 19 (WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added. 20 (WebCore::Internals::setAutomaticLinkDetectionEnabled): Added. 21 (WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added. 22 (WebCore::Internals::setAutomaticTextReplacementEnabled): Added. 23 (WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added. 24 * testing/Internals.h: 25 * testing/Internals.idl: 26 1 27 2013-04-12 Alberto Garcia <agarcia@igalia.com> 2 28 -
trunk/Source/WebCore/WebCore.exp.in
r148245 r148282 926 926 __ZN7WebCore6Editor26increaseSelectionListLevelEv 927 927 __ZN7WebCore6Editor28replaceSelectionWithFragmentEN3WTF10PassRefPtrINS_16DocumentFragmentEEEbbb 928 __ZN7WebCore6Editor28toggleAutomaticLinkDetectionEv 928 929 __ZN7WebCore6Editor29canDecreaseSelectionListLevelEv 929 930 __ZN7WebCore6Editor29canIncreaseSelectionListLevelEv … … 931 932 __ZN7WebCore6Editor30deleteSelectionWithSmartDeleteEb 932 933 __ZN7WebCore6Editor30pasteAsPlainTextBypassingDHTMLEv 934 __ZN7WebCore6Editor30toggleAutomaticTextReplacementEv 935 __ZN7WebCore6Editor31isAutomaticLinkDetectionEnabledEv 936 __ZN7WebCore6Editor31toggleAutomaticDashSubstitutionEv 933 937 __ZN7WebCore6Editor32guessesForUngrammaticalSelectionEv 938 __ZN7WebCore6Editor32toggleAutomaticQuoteSubstitutionEv 934 939 __ZN7WebCore6Editor33increaseSelectionListLevelOrderedEv 940 __ZN7WebCore6Editor33isAutomaticTextReplacementEnabledEv 941 __ZN7WebCore6Editor33toggleAutomaticSpellingCorrectionEv 942 __ZN7WebCore6Editor34isAutomaticDashSubstitutionEnabledEv 935 943 __ZN7WebCore6Editor34setMarkedTextMatchesAreHighlightedEb 936 944 __ZN7WebCore6Editor35increaseSelectionListLevelUnorderedEv 945 __ZN7WebCore6Editor35isAutomaticQuoteSubstitutionEnabledEv 937 946 __ZN7WebCore6Editor35setIgnoreCompositionSelectionChangeEb 947 __ZN7WebCore6Editor36isAutomaticSpellingCorrectionEnabledEv 938 948 __ZN7WebCore6Editor38commandIsSupportedFromMenuOrKeyBindingERKN3WTF6StringE 939 949 __ZN7WebCore6Editor39insertParagraphSeparatorInQuotedContentEv -
trunk/Source/WebCore/testing/Internals.cpp
r148123 r148282 1514 1514 void Internals::setContinuousSpellCheckingEnabled(bool enabled, ExceptionCode&) 1515 1515 { 1516 if (!contextDocument() || !contextDocument()->frame() || !contextDocument()->frame()->editor())1516 if (!contextDocument() || !contextDocument()->frame()) 1517 1517 return; 1518 1518 1519 1519 if (enabled != contextDocument()->frame()->editor()->isContinuousSpellCheckingEnabled()) 1520 1520 contextDocument()->frame()->editor()->toggleContinuousSpellChecking(); 1521 } 1522 1523 void Internals::setAutomaticQuoteSubstitutionEnabled(bool enabled, ExceptionCode&) 1524 { 1525 if (!contextDocument() || !contextDocument()->frame()) 1526 return; 1527 1528 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 1529 if (enabled != contextDocument()->frame()->editor()->isAutomaticQuoteSubstitutionEnabled()) 1530 contextDocument()->frame()->editor()->toggleAutomaticQuoteSubstitution(); 1531 #else 1532 UNUSED_PARAM(enabled); 1533 #endif 1534 } 1535 1536 void Internals::setAutomaticLinkDetectionEnabled(bool enabled, ExceptionCode&) 1537 { 1538 if (!contextDocument() || !contextDocument()->frame()) 1539 return; 1540 1541 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 1542 if (enabled != contextDocument()->frame()->editor()->isAutomaticLinkDetectionEnabled()) 1543 contextDocument()->frame()->editor()->toggleAutomaticLinkDetection(); 1544 #else 1545 UNUSED_PARAM(enabled); 1546 #endif 1547 } 1548 1549 void Internals::setAutomaticDashSubstitutionEnabled(bool enabled, ExceptionCode&) 1550 { 1551 if (!contextDocument() || !contextDocument()->frame()) 1552 return; 1553 1554 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 1555 if (enabled != contextDocument()->frame()->editor()->isAutomaticDashSubstitutionEnabled()) 1556 contextDocument()->frame()->editor()->toggleAutomaticDashSubstitution(); 1557 #else 1558 UNUSED_PARAM(enabled); 1559 #endif 1560 } 1561 1562 void Internals::setAutomaticTextReplacementEnabled(bool enabled, ExceptionCode&) 1563 { 1564 if (!contextDocument() || !contextDocument()->frame()) 1565 return; 1566 1567 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 1568 if (enabled != contextDocument()->frame()->editor()->isAutomaticTextReplacementEnabled()) 1569 contextDocument()->frame()->editor()->toggleAutomaticTextReplacement(); 1570 #else 1571 UNUSED_PARAM(enabled); 1572 #endif 1573 } 1574 1575 void Internals::setAutomaticSpellingCorrectionEnabled(bool enabled, ExceptionCode&) 1576 { 1577 if (!contextDocument() || !contextDocument()->frame()) 1578 return; 1579 1580 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 1581 if (enabled != contextDocument()->frame()->editor()->isAutomaticSpellingCorrectionEnabled()) 1582 contextDocument()->frame()->editor()->toggleAutomaticSpellingCorrection(); 1583 #else 1584 UNUSED_PARAM(enabled); 1585 #endif 1521 1586 } 1522 1587 -
trunk/Source/WebCore/testing/Internals.h
r148050 r148282 202 202 bool hasAutocorrectedMarker(Document*, int from, int length, ExceptionCode&); 203 203 void setContinuousSpellCheckingEnabled(bool enabled, ExceptionCode&); 204 void setAutomaticQuoteSubstitutionEnabled(bool enabled, ExceptionCode&); 205 void setAutomaticLinkDetectionEnabled(bool enabled, ExceptionCode&); 206 void setAutomaticDashSubstitutionEnabled(bool enabled, ExceptionCode&); 207 void setAutomaticTextReplacementEnabled(bool enabled, ExceptionCode&); 208 void setAutomaticSpellingCorrectionEnabled(bool enabled, ExceptionCode&); 204 209 205 210 bool isOverwriteModeEnabled(Document*, ExceptionCode&); -
trunk/Source/WebCore/testing/Internals.idl
r148050 r148282 169 169 boolean hasAutocorrectedMarker(in Document document, in long from, in long length) raises (DOMException); 170 170 void setContinuousSpellCheckingEnabled(in boolean enabled) raises (DOMException); 171 void setAutomaticQuoteSubstitutionEnabled(in boolean enabled) raises (DOMException); 172 void setAutomaticLinkDetectionEnabled(in boolean enabled) raises (DOMException); 173 void setAutomaticDashSubstitutionEnabled(in boolean enabled) raises (DOMException); 174 void setAutomaticTextReplacementEnabled(in boolean enabled) raises (DOMException); 175 void setAutomaticSpellingCorrectionEnabled(in boolean enabled) raises (DOMException); 171 176 172 177 boolean isOverwriteModeEnabled(in Document document) raises (DOMException); -
trunk/Tools/ChangeLog
r148276 r148282 1 2013-04-12 Ryosuke Niwa <rniwa@webkit.org> 2 3 [Mac] Enable spellchecking tests added in r141471 4 https://bugs.webkit.org/show_bug.cgi?id=108525 5 6 Reviewed by Darin Adler. 7 8 * DumpRenderTree/mac/DumpRenderTree.mm: 9 (createWebViewAndOffscreenWindow): 10 (resetDefaultsToConsistentValues): 11 * WebKitTestRunner/TestController.cpp: 12 (WTR::TestController::resetStateToConsistentValues): 13 1 14 2013-04-12 Manuel Rego Casasnovas <rego@igalia.com> 2 15 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r147994 r148282 540 540 541 541 [webView setContinuousSpellCheckingEnabled:YES]; 542 [webView setAutomaticQuoteSubstitutionEnabled:NO]; 543 [webView setAutomaticLinkDetectionEnabled:NO]; 544 [webView setAutomaticDashSubstitutionEnabled:NO]; 545 [webView setAutomaticTextReplacementEnabled:NO]; 546 [webView setAutomaticSpellingCorrectionEnabled:YES]; 542 547 [webView setDefersCallbacks:NO]; 543 548 [webView setGrammarCheckingEnabled:YES]; … … 601 606 @"message", @"mesage", 602 607 @"would", @"wouldn", 608 @"welcome", @"wellcome", 609 @"uppercase", @"upper case", 603 610 nil] forKey:@"NSTestCorrectionDictionary"]; 604 611 #endif -
trunk/Tools/WebKitTestRunner/TestController.cpp
r145869 r148282 578 578 WKTextCheckerContinuousSpellCheckingEnabledStateChanged(true); 579 579 #endif 580 #if USE(AUTOMATIC_TEXT_REPLACEMENT) 581 WKTextCheckerAutomaticQuoteSubstitutionEnabledStateChanged(false); 582 WKTextCheckerAutomaticLinkDetectionEnabledStateChanged(false); 583 WKTextCheckerAutomaticDashSubstitutionEnabledStateChanged(false); 584 WKTextCheckerAutomaticTextReplacementEnabledStateChanged(false); 585 WKTextCheckerAutomaticSpellingCorrectionEnabledStateChanged(true); 586 #endif 580 587 581 588 // in the case that a test using the chrome input field failed, be sure to clean up for the next test
Note: See TracChangeset
for help on using the changeset viewer.