Changeset 148314 in webkit

Timestamp:

Apr 12, 2013 4:43:13 PM (11 years ago)

Author:

mhahnenberg@apple.com

Message:

Block freeing thread should call Region::destroy instead of delete
​https://bugs.webkit.org/show_bug.cgi?id=114544

Reviewed by Oliver Hunt.

Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of
the state of the Region. We should call destroy() instead.

• heap/BlockAllocator.cpp:

(JSC::BlockAllocator::releaseFreeRegions):
(JSC::BlockAllocator::blockFreeingThreadMain):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/BlockAllocator.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-04-12  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        Block freeing thread should call Region::destroy instead of delete
+        https://bugs.webkit.org/show_bug.cgi?id=114544
+
+        Reviewed by Oliver Hunt.
+
+        Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of 
+        the state of the Region. We should call destroy() instead.
+
+        * heap/BlockAllocator.cpp:
+        (JSC::BlockAllocator::releaseFreeRegions):
+        (JSC::BlockAllocator::blockFreeingThreadMain):
+
 2013-04-11  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/JavaScriptCore/heap/BlockAllocator.cpp

@@ -79 +79 @@
             break;
 
-        delete region;
+        region->destroy();
     }
 }
@@ -151 +151 @@
                 break;
             
-            delete region;
+            region->destroy();
         }
     }