Changeset 148521 in webkit

Timestamp:

Apr 16, 2013 10:18:38 AM (11 years ago)

Author:

jonlee@apple.com

Message:

RenderView should bail out of paintBoxDecorations() when painting with a different renderer
​https://bugs.webkit.org/show_bug.cgi?id=114665
<rdar://problem/13434884>

Reviewed by Simon Fraser.

• rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations): Add a check to see if we should paint within the renderer.
This check exists in all other implementations of paintBoxDecorations(), and correctly avoids painting the
decorations if the root provided is not the RenderView.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-15  Jon Lee  <jonlee@apple.com>
+
+        RenderView should bail out of paintBoxDecorations() when painting with a different renderer
+        https://bugs.webkit.org/show_bug.cgi?id=114665
+        <rdar://problem/13434884>
+
+        Reviewed by Simon Fraser.
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::paintBoxDecorations): Add a check to see if we should paint within the renderer.
+        This check exists in all other implementations of paintBoxDecorations(), and correctly avoids painting the
+        decorations if the root provided is not the RenderView.
+
 2013-04-16  Max Vujovic  <mvujovic@adobe.com>
 

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -427 +427 @@
 void RenderView::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint&)
 {
+    if (!paintInfo.shouldPaintWithinRoot(this))
+        return;
+
     // Check to see if we are enclosed by a layer that requires complex painting rules.  If so, we cannot blit
     // when scrolling, and we need to use slow repaints.  Examples of layers that require this are transparent layers,