Changeset 148592 in webkit

Timestamp:

Apr 17, 2013 12:38:38 AM (11 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=111938

Reviewed by Anders Carlsson.

Add API to the web extensions API to get the identifier of a web
page.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
• UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(methodCallCallback): Check the page ID matches the one returned
by webkit_web_page_get_id().

• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_get_id):

• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt (modified) (1 diff)
• UIProcess/API/gtk/tests/WebExtensionTest.cpp (modified) (1 diff)
• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp (modified) (1 diff)
• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-04-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API
+        https://bugs.webkit.org/show_bug.cgi?id=111938
+
+        Reviewed by Anders Carlsson.
+
+        Add API to the web extensions API to get the identifier of a web
+        page.
+
+        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
+        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
+        (methodCallCallback): Check the page ID matches the one returned
+        by webkit_web_page_get_id().
+        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
+        (webkit_web_page_get_id):
+        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:
+
 2013-04-16  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt

@@ -962 +962 @@
 WebKitWebPage
 webkit_web_page_get_dom_document
+webkit_web_page_get_id
 
 <SUBSECTION Standard>

trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp

@@ -69 +69 @@
             return;
         }
+        g_assert_cmpuint(webkit_web_page_get_id(page), ==, pageID);
 
         WebKitDOMDocument* document = webkit_web_page_get_dom_document(page);

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp

@@ -253 +253 @@
     return kit(coreFrame->document());
 }
+
+/**
+ * webkit_web_page_get_id:
+ * @web_page: a #WebKitWebPage
+ *
+ * Get the identifier of the #WebKitWebPage
+ *
+ * Returns: the identifier of @web_page
+ */
+guint64 webkit_web_page_get_id(WebKitWebPage* webPage)
+{
+    g_return_val_if_fail(WEBKIT_IS_WEB_PAGE(webPage), 0);
+
+    return webPage->priv->webPage->pageID();
+}

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h

@@ -58 +58 @@
 webkit_web_page_get_dom_document (WebKitWebPage *web_page);
 
+WEBKIT_API guint64
+webkit_web_page_get_id           (WebKitWebPage *web_page);
+
 G_END_DECLS