Changeset 148614 in webkit

Timestamp:

Apr 17, 2013 9:14:37 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

getAttribute does not behave correctly for mixed-case attributes on HTML elements
​https://bugs.webkit.org/show_bug.cgi?id=105713

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-04-17
Reviewed by Andreas Kling.

Source/WebCore:

getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]

Test: fast/dom/Element/getAttribute-case-insensitivity.html

• dom/Element.h:

(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether or not the attribute's case should be ignored
before comparison but we don't really convert the passed name to lowercase
before carrying out the comparison.

Thus, when called from APIs such as getAttribute() and getAttributeNode()
which do not explicitally convert the attribute name to lowercase
before calling on this method, it fails to carry out a case-insensitive
search.

Have thus made changes to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.

LayoutTests:

• fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
• fast/dom/Element/getAttribute-case-insensitivity.html: Added.

Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Element/getAttribute-case-insensitivity-expected.txt (added)
• LayoutTests/fast/dom/Element/getAttribute-case-insensitivity.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-17  Arpita Bahuguna  <a.bah@samsung.com>
+
+        getAttribute does not behave correctly for mixed-case attributes on HTML elements
+        https://bugs.webkit.org/show_bug.cgi?id=105713
+
+        Reviewed by Andreas Kling.
+
+        * fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
+        * fast/dom/Element/getAttribute-case-insensitivity.html: Added.
+        Layout test added for verifying that getAttribute() and getAttributeNode()
+        APIs convert the passed attribute name to lowercase before comparing
+        against the existing attributes.
+
 2013-04-17  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-17  Arpita Bahuguna  <a.bah@samsung.com>
+
+        getAttribute does not behave correctly for mixed-case attributes on HTML elements
+        https://bugs.webkit.org/show_bug.cgi?id=105713
+
+        Reviewed by Andreas Kling.
+
+        getAttribute() and getAttributeNode() APIs do not convert the
+        passed attribute name to lowercase before comparing against the
+        existing attributes.
+        The specification however states that the passed name should
+        be converted to ASCII lowercase before checking for the existence
+        of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]
+
+        Test: fast/dom/Element/getAttribute-case-insensitivity.html
+
+        * dom/Element.h:
+        (WebCore::ElementData::getAttributeItemIndex):
+        getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
+        which specifies whether or not the attribute's case should be ignored
+        before comparison but we don't really convert the passed name to lowercase
+        before carrying out the comparison.
+
+        Thus, when called from APIs such as getAttribute() and getAttributeNode()
+        which do not explicitally convert the attribute name to lowercase
+        before calling on this method, it fails to carry out a case-insensitive
+        search.
+
+        Have thus made changes to convert the passed attribute's name to
+        lowercase if 'shouldIgnoreAttributeCase' is true.
+
 2013-04-17  John Griggs  <jgriggs@blackberry.com>
 

trunk/Source/WebCore/dom/Element.h

@@ -976 +976 @@
     bool doSlowCheck = shouldIgnoreAttributeCase;
 
+    const AtomicString caseAdjustedName = shouldIgnoreAttributeCase ? name.lower() : name;
     // Optimize for the case where the attribute exists and its name exactly matches.
     for (unsigned i = 0; i < len; ++i) {
         const Attribute* attribute = attributeItem(i);
         if (!attribute->name().hasPrefix()) {
-            if (name == attribute->localName())
+            if (caseAdjustedName == attribute->localName())
                 return i;
         } else