Changeset 148617 in webkit


Ignore:
Timestamp:
Apr 17, 2013 9:42:45 AM (11 years ago)
Author:
Chris Fleizach
Message:

Source/WebCore: AX: When img@alt is undefined, WebKit should use @title as accessibility label if available
https://bugs.webkit.org/show_bug.cgi?id=114535

Reviewed by Tim Horton.

Don't hide images from Accessibility that have the title attribute on them.

Test: accessibility/empty-image-with-title.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

LayoutTests: When img@alt is undefined, WebKit should use @title as accessibility label if available
https://bugs.webkit.org/show_bug.cgi?id=114535

Reviewed by Tim Horton.

  • accessibility/empty-image-with-title-expected.txt: Added.
  • accessibility/empty-image-with-title.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r148614 r148617  
     12013-04-17  Chris Fleizach  <cfleizach@apple.com>
     2
     3        When img@alt is undefined, WebKit should use @title as accessibility label if available
     4        https://bugs.webkit.org/show_bug.cgi?id=114535
     5
     6        Reviewed by Tim Horton.
     7
     8        * accessibility/empty-image-with-title-expected.txt: Added.
     9        * accessibility/empty-image-with-title.html: Added.
     10
    1112013-04-17  Arpita Bahuguna  <a.bah@samsung.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r148614 r148617  
     12013-04-17  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: When img@alt is undefined, WebKit should use @title as accessibility label if available
     4        https://bugs.webkit.org/show_bug.cgi?id=114535
     5
     6        Reviewed by Tim Horton.
     7
     8        Don't hide images from Accessibility that have the title attribute on them.
     9
     10        Test: accessibility/empty-image-with-title.html
     11
     12        * accessibility/AccessibilityRenderObject.cpp:
     13        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
     14
    1152013-04-17  Arpita Bahuguna  <a.bah@samsung.com>
    216
  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r148539 r148617  
    12481248            if (!alt.isNull())
    12491249                return true;
     1250            // If an image has a title attribute on it, accessibility should be lenient and allow it to appear in the hierarchy (according to WAI-ARIA).
     1251            if (!getAttribute(titleAttr).isEmpty())
     1252                return false;
    12501253        }
    12511254       
Note: See TracChangeset for help on using the changeset viewer.