Changeset 148667 in webkit


Ignore:
Timestamp:
Apr 18, 2013 5:43:55 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

removei build warning (unused parameter )
​https://bugs.webkit.org/show_bug.cgi?id=114670

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.

remove warning (unused parameter ) in
Source/WebKit/blackberry/WebCoreSupport

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
(WebCore::ChromeClientBlackBerry::needTouchEvents):
(WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValue):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):

  • WebCoreSupport/NetworkInfoClientBlackBerry.cpp:

(WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
(WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::requestUserMedia):

Location:
trunk/Source/WebKit/blackberry
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/blackberry/ChangeLog

    r148635 r148667  
     12013-04-18  Xuefei Ren  <xren@blackberry.com>
     2
     3        removei build  warning (unused parameter )
     4        https://bugs.webkit.org/show_bug.cgi?id=114670
     5
     6        Reviewed by Rob Buis.
     7
     8        remove warning (unused parameter ) in
     9        Source/WebKit/blackberry/WebCoreSupport
     10
     11        * WebCoreSupport/ChromeClientBlackBerry.cpp:
     12        (WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
     13        (WebCore::ChromeClientBlackBerry::needTouchEvents):
     14        (WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
     15        * WebCoreSupport/DatePickerClient.cpp:
     16        (WebCore::DatePickerClient::setValue):
     17        * WebCoreSupport/EditorClientBlackBerry.cpp:
     18        (WebCore::EditorClientBlackBerry::checkSpellingOfString):
     19        (WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
     20        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
     21        (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
     22        (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
     23        (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
     24        * WebCoreSupport/InspectorClientBlackBerry.cpp:
     25        (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
     26        * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
     27        (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
     28        (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
     29        * WebCoreSupport/SelectPopupClient.cpp:
     30        (WebCore::SelectPopupClient::generateHTML):
     31        * WebCoreSupport/UserMediaClientImpl.cpp:
     32        (WebCore::UserMediaClientImpl::requestUserMedia):
     33
    1342013-04-17  Nima Ghanavatian  <nghanavatian@blackberry.com>
    235

  • trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

    r148451 r148667  
    446446}
    447447
    448 void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult& result, unsigned int modifierFlags)
     448void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult&, unsigned)
    449449{
    450450    notImplemented();
    … …  
    668668
    669669#if ENABLE(TOUCH_EVENTS)
    670 void ChromeClientBlackBerry::needTouchEvents(bool value)
    671 {
    672 }
    673 #endif
    674 
    675 void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t spaceNeeded)
     670void ChromeClientBlackBerry::needTouchEvents(bool)
     671{
     672}
     673#endif
     674
     675void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t)
    676676{
    677677    notImplemented();

  • trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp

    r144426 r148667  
    139139}
    140140
    141 void DatePickerClient::setValue(const String& value)
     141void DatePickerClient::setValue(const String&)
    142142{
    143143    notImplemented();

  • trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp

    r148575 r148667  
    564564}
    565565
    566 void EditorClientBlackBerry::checkSpellingOfString(const UChar* text, int textLength, int* misspellLocation, int* misspellLength)
    567 {
    568     notImplemented();
    569 }
    570 
    571 WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String& misspelledWord)
     566void EditorClientBlackBerry::checkSpellingOfString(const UChar*, int, int*, int*)
     567{
     568    notImplemented();
     569}
     570
     571WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String&)
    572572{
    573573    notImplemented();

  • trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp

    r148451 r148667  
    265265}
    266266
    267 void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String& frameName)
     267void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String&)
    268268{
    269269    if (ScriptController::processingUserGesture() && !m_webPagePrivate->m_pluginMayOpenNewTab) {
    … …  
    504504}
    505505
    506 void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, const ResourceResponse& response)
     506void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const ResourceResponse& response)
    507507{
    508508    if (m_webPagePrivate->m_dumpRenderTree)
    … …  
    10101010}
    10111011
    1012 bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader* loader, long unsigned identifier)
     1012bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader*, long unsigned)
    10131013{
    10141014#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)

  • trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp

    r122838 r148667  
    104104}
    105105
    106 void InspectorClientBlackBerry::updateInspectorStateCookie(const String& cookie)
     106void InspectorClientBlackBerry::updateInspectorStateCookie(const String&)
    107107{
    108108    // If this is implemented, we should override and return true in InspectorStateClient::supportsInspectorStateUpdates().

  • trunk/Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp

    r137568 r148667  
    100100}
    101101
    102 void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType newInternalNetworkType)
     102void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType)
    103103{
    104104    if (m_isActive) {
    … …  
    108108}
    109109
    110 void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType newCellularType)
     110void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType)
    111111{
    112112    // Only dispatch to listeners if the current type is cellular.

  • trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp

    r143607 r148667  
    6565}
    6666
    67 void SelectPopupClient::generateHTML(bool multiple, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
     67void SelectPopupClient::generateHTML(bool, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
    6868    const int* itemType, bool* selecteds)
    6969{

  • trunk/Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp

    r146865 r148667  
    114114}
    115115
    116 void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector& audioSources, const MediaStreamSourceVector& videoSources)
     116void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector&, const MediaStreamSourceVector&)
    117117{
    118118    UserMediaRequest* request = prpRequest.get();
Note: See TracChangeset for help on using the changeset viewer.