Changeset 148700 in webkit


Ignore:
Timestamp:
Apr 18, 2013 1:39:32 PM (11 years ago)
Author:
jer.noble@apple.com
Message:

CodeGeneratorJS.pm should generate "isFiringEventListeners()" check in isReachableFromOpaqueRoots()
https://bugs.webkit.org/show_bug.cgi?id=114784

Reviewed by Geoffrey Garen.

EventTarget subclasses shouldn't have to use CustomIsReachable directives
in order to keep their wrappers alive while firing event listeners.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r148696 r148700  
     12013-04-18  Jer Noble  <jer.noble@apple.com>
     2
     3        CodeGeneratorJS.pm should generate "isFiringEventListeners()" check in isReachableFromOpaqueRoots()
     4        https://bugs.webkit.org/show_bug.cgi?id=114784
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        EventTarget subclasses shouldn't have to use CustomIsReachable directives
     9        in order to keep their wrappers alive while firing event listeners.
     10
     11        * bindings/scripts/CodeGeneratorJS.pm:
     12        (GenerateImplementation):
     13
    1142013-04-17  Geoffrey Garen  <ggaren@apple.com>
    215
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r148696 r148700  
    26402640            push(@implContent, "        return true;\n");
    26412641        }
     2642        if ($codeGenerator->InheritsExtendedAttribute($interface, "EventTarget")) {
     2643            push(@implContent, "    if (js${interfaceName}->impl()->isFiringEventListeners())\n");
     2644            push(@implContent, "        return true;\n");
     2645        }
    26422646        if ($codeGenerator->InheritsInterface($interface, "Node")) {
    26432647            push(@implContent, "    if (JSNodeOwner::isReachableFromOpaqueRoots(handle, 0, visitor))\n");
Note: See TracChangeset for help on using the changeset viewer.