Changeset 148770 in webkit

Timestamp:

Apr 19, 2013 2:10:34 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=114847

Reviewed by Geoffrey Garen.

For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
for invoking appendStyleNodeOpenTag. This is a bad idea.

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::appendText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/markup.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-19  Benjamin Poulain  <benjamin@webkit.org>
+
+        StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
+        https://bugs.webkit.org/show_bug.cgi?id=114847
+
+        Reviewed by Geoffrey Garen.
+
+        For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
+        for invoking appendStyleNodeOpenTag. This is a bad idea.
+
+        * editing/markup.cpp:
+        (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
+        (WebCore::StyledMarkupAccumulator::appendText):
+
 2013-04-19  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/editing/markup.cpp

@@ -198 +198 @@
         out.appendLiteral("<span style=\"");
     appendAttributeValue(out, style->asText(), document->isHTMLDocument());
-    out.append('\"');
-    out.append('>');
+    out.appendLiteral("\">");
 }
 
@@ -235 +234 @@
         wrappingStyle->style()->setProperty(CSSPropertyFloat, CSSValueNone);
 
-        StringBuilder openTag;
-        appendStyleNodeOpenTag(openTag, wrappingStyle->style(), text->document());
-        out.append(openTag.characters(), openTag.length());
+        appendStyleNodeOpenTag(out, wrappingStyle->style(), text->document());
     }