Changeset 148881 in webkit


Ignore:
Timestamp:
Apr 22, 2013 7:26:28 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

fix build warning(unused parameter)
​https://bugs.webkit.org/show_bug.cgi?id=114855

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Source/WebCore:

remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):

  • platform/graphics/blackberry/FontBlackBerry.cpp:

(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):

  • platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::drawTile):

  • platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):

  • platform/graphics/blackberry/PatternBlackBerry.cpp:

(WebCore::Pattern::platformPattern):

Source/WebKit/blackberry:

remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::extractedTextRequest):

Tools:

remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp

  • DumpRenderTree/blackberry/EventSender.cpp:

(getDragModeCallback):

Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r148879 r148881  
     12013-04-22  Xuefei Ren  <xren@blackberry.com>
     2
     3
     4        fix build warning(unused parameter)
     5        https://bugs.webkit.org/show_bug.cgi?id=114855
     6
     7        Reviewed by Rob Buis.
     8
     9        remove warning(unused parameter) in
     10        Source/WebCore/platform/graphics/blackberry
     11
     12        * platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
     13        (WebCore::CanvasLayerCompositingThreadClient::drawTextures):
     14        (WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
     15        (WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
     16        * platform/graphics/blackberry/FontBlackBerry.cpp:
     17        (WebCore::Font::offsetForPositionForComplexText):
     18        * platform/graphics/blackberry/FontCacheBlackBerry.cpp:
     19        (WebCore::FontCache::getSimilarFontPlatformData):
     20        (WebCore::FontCache::getTraitsInFamily):
     21        * platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
     22        (WebCore::GlyphPage::fill):
     23        * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
     24        (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
     25        * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
     26        (WebCore::GraphicsContext::drawConvexPolygon):
     27        (WebCore::GraphicsContext::fillRect):
     28        (WebCore::GraphicsContext::fillRoundedRect):
     29        (WebCore::GraphicsContext::roundToDevicePixels):
     30        (WebCore::GraphicsContext::setPlatformShadow):
     31        (WebCore::GraphicsContext::clipConvexPolygon):
     32        (WebCore::GraphicsContext::setURLForRect):
     33        (WebCore::GraphicsContext::setPlatformStrokeColor):
     34        (WebCore::GraphicsContext::setPlatformFillColor):
     35        (WebCore::GraphicsContext::setPlatformCompositeOperation):
     36        * platform/graphics/blackberry/ImageBlackBerry.cpp:
     37        (WebCore::BitmapImage::draw):
     38        (WebCore::Image::drawPattern):
     39        * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
     40        (WebCore::flushAndDraw):
     41        (WebCore::ImageBuffer::ImageBuffer):
     42        (WebCore::ImageBuffer::copyImage):
     43        (WebCore::ImageBuffer::draw):
     44        (WebCore::ImageBuffer::platformTransformColorSpace):
     45        * platform/graphics/blackberry/LayerTiler.cpp:
     46        (WebCore::LayerTiler::drawTile):
     47        * platform/graphics/blackberry/PathBlackBerry.cpp:
     48        (WebCore::GraphicsContext::drawFocusRing):
     49        (WebCore::GraphicsContext::clipPath):
     50        * platform/graphics/blackberry/PatternBlackBerry.cpp:
     51        (WebCore::Pattern::platformPattern):
     52
    1532013-04-22  Mike Fenton  <mifenton@rim.com>
    254

  • trunk/Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp

    r144465 r148881  
    5959}
    6060
    61 void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program&)
     61void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double, const GLES2Program&)
    6262{
    6363    if (!m_buffer)
    … …  
    7171}
    7272
    73 void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread* layer)
     73void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread*)
    7474{
    7575    // Nothing to do here, the buffer is not owned by us.
    7676}
    7777
    78 void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread* layer)
     78void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread*)
    7979{
    8080    if (!m_buffer)

  • trunk/Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp

    r144612 r148881  
    6363
    6464// Return the code point index for the given |x| offset into the text run.
    65 int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool includePartialGlyphs) const
     65int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool) const
    6666{
    6767    // FIXME: This truncation is not a problem for HTML, but only affects SVG, which passes floating-point numbers

  • trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp

    r147639 r148881  
    179179}
    180180
    181 PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font& font)
     181PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font&)
    182182{
    183183    return 0;
    … …  
    213213}
    214214
    215 void FontCache::getTraitsInFamily(const AtomicString& familyName, Vector<unsigned>& traitsMasks)
     215void FontCache::getTraitsInFamily(const AtomicString&, Vector<unsigned>&)
    216216{
    217217    notImplemented();

  • trunk/Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp

    r144612 r148881  
    4848};
    4949
    50 bool GlyphPage::fill(unsigned offset, unsigned length, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
     50bool GlyphPage::fill(unsigned offset, unsigned, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
    5151{
    5252    bool haveGlyphs = false;

  • trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp

    r148680 r148881  
    387387}
    388388
    389 bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool ignoreGammaAndColorProfile)
     389bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool)
    390390{
    391391    if (!m_image)

  • trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp

    r145226 r148881  
    175175}
    176176
    177 void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool shouldAntialias)
     177void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
    178178{
    179179    if (paintingDisabled())
    … …  
    201201}
    202202
    203 void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace colorSpace)
     203void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace)
    204204{
    205205    if (paintingDisabled())
    … …  
    235235}
    236236
    237 void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace colorSpace)
     237void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace)
    238238{
    239239    if (paintingDisabled())
    … …  
    246246}
    247247
    248 FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode roundingMode)
     248FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode)
    249249{
    250250    return rect;
    251251}
    252252
    253 void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace colorSpace)
     253void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace)
    254254{
    255255    if (paintingDisabled())
    … …  
    354354}
    355355
    356 void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool antialias)
     356void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
    357357{
    358358    if (paintingDisabled())
    … …  
    396396}
    397397
    398 void GraphicsContext::setURLForRect(const KURL& link, const IntRect& destRect)
     398void GraphicsContext::setURLForRect(const KURL&, const IntRect&)
    399399{
    400400}
    … …  
    408408}
    409409
    410 void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace colorSpace)
     410void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace)
    411411{
    412412    if (paintingDisabled())
    … …  
    432432}
    433433
    434 void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace colorSpace)
     434void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace)
    435435{
    436436    if (paintingDisabled())
    … …  
    440440}
    441441
    442 void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode blendMode)
     442void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode)
    443443{
    444444    if (paintingDisabled())

  • trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp

    r147622 r148881  
    125125}
    126126
    127 void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
     127void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
    128128{
    129129    startAnimation();
    … …  
    173173}
    174174
    175 void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode blendMode)
     175void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode)
    176176{
    177177    NativeImagePtr image = nativeImageForCurrentFrame();

  • trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp

    r146351 r148881  
    114114}
    115115
    116 static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool useLowQualityScale)
     116static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool)
    117117{
    118118    if (!makeBufferCurrent(object->m_window)) {
    … …  
    154154}
    155155
    156 ImageBuffer::ImageBuffer(const IntSize& size, float resolutionScale, ColorSpace colorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
     156ImageBuffer::ImageBuffer(const IntSize& size, float, ColorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
    157157    : m_size(size)
    158158    , m_logicalSize(size)
    … …  
    208208}
    209209
    210 PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy copyBehavior, ScaleBehavior) const
     210PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy, ScaleBehavior) const
    211211{
    212212    // FIXME respect copyBehaviour enum.
    … …  
    225225}
    226226
    227 void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode blendMode, bool useLowQualityScale)
     227void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode, bool useLowQualityScale)
    228228{
    229229    m_data.draw(m_context.get(), context, styleColorSpace, destRect, srcRect, op, useLowQualityScale);
    … …  
    236236}
    237237
    238 void ImageBuffer::platformTransformColorSpace(const Vector<int>& lookUpTable)
     238void ImageBuffer::platformTransformColorSpace(const Vector<int>&)
    239239{
    240240}

  • trunk/Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp

    r148192 r148881  
    447447}
    448448
    449 bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program& program)
     449bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program&)
    450450{
    451451    TransformationMatrix drawTransform = layer->drawTransform();

  • trunk/Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp

    r147386 r148881  
    232232}
    233233
    234 void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color)
     234void GraphicsContext::drawFocusRing(const Vector<IntRect>&, int, int, const Color&)
    235235{
    236236    notImplemented();
    237237}
    238238
    239 void GraphicsContext::drawFocusRing(const Path& path, int width, int offset, const Color& color)
     239void GraphicsContext::drawFocusRing(const Path&, int, int, const Color&)
    240240{
    241241    notImplemented();
    … …  
    264264}
    265265
    266 void GraphicsContext::clipPath(const Path& path, WindRule clipRule)
     266void GraphicsContext::clipPath(const Path& path, WindRule)
    267267{
    268268    if (path.platformPath()->isRectangular())

  • trunk/Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp

    r144612 r148881  
    3737}
    3838
    39 PlatformPatternPtr Pattern::platformPattern(const AffineTransform& patternTransform)
     39PlatformPatternPtr Pattern::platformPattern(const AffineTransform&)
    4040{
    4141    if (m_pattern)

  • trunk/Source/WebKit/blackberry/ChangeLog

    r148880 r148881  
     12013-04-22  Xuefei Ren  <xren@blackberry.com>
     2
     3        fix build warning(unused parameter)
     4        https://bugs.webkit.org/show_bug.cgi?id=114855
     5
     6        Reviewed by Rob Buis.
     7
     8        remove warning(unused parameter) in
     9        Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
     10
     11        * WebKitSupport/InputHandler.cpp:
     12        (BlackBerry::WebKit::InputHandler::extractedTextRequest):
     13
    1142013-04-22  Xan Lopez  <xlopez@igalia.com>
    215

  • trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

    r148879 r148881  
    22332233}
    22342234
    2235 extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t* request, int32_t flags)
     2235extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t*, int32_t flags)
    22362236{
    22372237    if (!isActiveTextEdit())

  • trunk/Tools/ChangeLog

    r148867 r148881  
     12013-04-22  Xuefei Ren  <xren@blackberry.com>
     2
     3        fix build warning(unused parameter)
     4        https://bugs.webkit.org/show_bug.cgi?id=114855
     5
     6        Reviewed by Rob Buis.
     7
     8        remove warning(unused parameter) in
     9        Tools/DumpRenderTree/blackberry/EventSender.cpp
     10
     11        * DumpRenderTree/blackberry/EventSender.cpp:
     12        (getDragModeCallback):
     13
    1142013-04-22  Alberto Garcia  <agarcia@igalia.com>
    215

  • trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp

    r148677 r148881  
    4848// Callbacks
    4949
    50 static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef* exception)
     50static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef*)
    5151{
    5252    notImplemented();
Note: See TracChangeset for help on using the changeset viewer.