Changeset 148984 in webkit

Timestamp:

Apr 23, 2013 12:59:13 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Inline SelectorQuery::matches, SelectorQuery::queryAll, SelectorQuery::queryFirst
​https://bugs.webkit.org/show_bug.cgi?id=115012

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

Each of these function has a single call site:
-SelectorQuery::matches from Element::webkitMatchesSelector.
-SelectorQuery::queryAll from Node::querySelectorAll.
-SelectorQuery::queryFirst from Node::querySelector.

Having a dedicated method to jump to was a little overkill.

• dom/SelectorQuery.cpp:
• dom/SelectorQuery.h:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/SelectorQuery.cpp (modified) (1 diff)
• dom/SelectorQuery.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-23  Benjamin Poulain  <bpoulain@apple.com>
+
+        Inline SelectorQuery::matches, SelectorQuery::queryAll, SelectorQuery::queryFirst
+        https://bugs.webkit.org/show_bug.cgi?id=115012
+
+        Reviewed by Andreas Kling.
+
+        Each of these function has a single call site:
+        -SelectorQuery::matches from Element::webkitMatchesSelector.
+        -SelectorQuery::queryAll from Node::querySelectorAll.
+        -SelectorQuery::queryFirst from Node::querySelector.
+
+        Having a dedicated method to jump to was a little overkill.
+
+        * dom/SelectorQuery.cpp:
+        * dom/SelectorQuery.h:
+        (WebCore::SelectorQuery::matches):
+        (WebCore::SelectorQuery::queryAll):
+        (WebCore::SelectorQuery::queryFirst):
+
 2013-04-23  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/dom/SelectorQuery.cpp

@@ -170 +170 @@
 }
 
-bool SelectorQuery::matches(Element* element) const
-{
-    return m_selectors.matches(element);
-}
-
-PassRefPtr<NodeList> SelectorQuery::queryAll(Node* rootNode) const
-{
-    return m_selectors.queryAll(rootNode);
-}
-
-PassRefPtr<Element> SelectorQuery::queryFirst(Node* rootNode) const
-{
-    return m_selectors.queryFirst(rootNode);
-}
-
 SelectorQuery* SelectorQueryCache::add(const AtomicString& selectors, Document* document, ExceptionCode& ec)
 {

trunk/Source/WebCore/dom/SelectorQuery.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2011, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -28 +28 @@
 
 #include "CSSSelectorList.h"
+#include "NodeList.h"
 #include <wtf/HashMap.h>
+#include <wtf/PassRefPtr.h>
 #include <wtf/Vector.h>
 #include <wtf/text/AtomicStringHash.h>
@@ -87 +89 @@
 };
 
+inline bool SelectorQuery::matches(Element* element) const
+{
+    return m_selectors.matches(element);
+}
+
+inline PassRefPtr<NodeList> SelectorQuery::queryAll(Node* rootNode) const
+{
+    return m_selectors.queryAll(rootNode);
+}
+
+inline PassRefPtr<Element> SelectorQuery::queryFirst(Node* rootNode) const
+{
+    return m_selectors.queryFirst(rootNode);
+}
+
 }