Changeset 148993 in webkit

Timestamp:

Apr 23, 2013 2:24:57 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Minor String usage fixes in WebCore/platform
​https://bugs.webkit.org/show_bug.cgi?id=115021

Reviewed by Andreas Kling.

Use ASCIILiteral when possible + minor fixes.

• platform/ContentType.cpp:

(WebCore::ContentType::codecs):

• platform/ContentType.h:

(ContentType):

• platform/Decimal.cpp:

(WebCore::Decimal::toString):

• platform/KURL.cpp:

(WebCore::KURL::setProtocol):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ContentType.cpp (modified) (3 diffs)
• platform/ContentType.h (modified) (2 diffs)
• platform/Decimal.cpp (modified) (3 diffs)
• platform/KURL.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-23  Benjamin Poulain  <benjamin@webkit.org>
+
+        Minor String usage fixes in WebCore/platform
+        https://bugs.webkit.org/show_bug.cgi?id=115021
+
+        Reviewed by Andreas Kling.
+
+        Use ASCIILiteral when possible + minor fixes.
+
+        * platform/ContentType.cpp:
+        (WebCore::ContentType::codecs):
+        * platform/ContentType.h:
+        (ContentType):
+        * platform/Decimal.cpp:
+        (WebCore::Decimal::toString):
+        * platform/KURL.cpp:
+        (WebCore::KURL::setProtocol):
+
 2013-04-23  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/platform/ContentType.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2006, 2008 Apple Inc.  All rights reserved.
+ * Copyright (C) 2006, 2008, 2013 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2009 Google Inc.  All rights reserved.
@@ -79 +79 @@
 Vector<String> ContentType::codecs() const
 {
-    String codecsParameter = parameter("codecs");
+    String codecsParameter = parameter(ASCIILiteral("codecs"));
 
     if (codecsParameter.isEmpty())
@@ -85 +85 @@
 
     Vector<String> codecs;
-    codecsParameter.split(",", codecs);
+    codecsParameter.split(',', codecs);
     for (size_t i = 0; i < codecs.size(); ++i)
         codecs[i] = codecs[i].simplifyWhiteSpace();

trunk/Source/WebCore/platform/ContentType.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
+ * Copyright (C) 2006, 2013 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2009 Google Inc.  All rights reserved.
  *
@@ -36 +36 @@
         explicit ContentType(const String& type);
 
-        String parameter (const String& parameterName) const;
+        String parameter(const String& parameterName) const;
         String type() const;
         Vector<String> codecs() const;

trunk/Source/WebCore/platform/Decimal.cpp

@@ -1 +1 @@
 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -946 +947 @@
     switch (m_data.formatClass()) {
     case EncodedData::ClassInfinity:
-        return sign() ? "-Infinity" : "Infinity";
+        return sign() ? ASCIILiteral("-Infinity") : ASCIILiteral("Infinity");
 
     case EncodedData::ClassNaN:
-        return "NaN";
+        return ASCIILiteral("NaN");
 
     case EncodedData::ClassNormal:
@@ -957 +958 @@
     default:
         ASSERT_NOT_REACHED();
-        return "";
+        return emptyString();
     }
 

trunk/Source/WebCore/platform/KURL.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2004, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2004, 2007, 2008, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
@@ -701 +701 @@
 
     if (!m_isValid) {
-        parse(newProtocol + ":" + m_string);
+        parse(newProtocol + ':' + m_string);
         return true;
     }