Changeset 149015 in webkit
- Timestamp:
- Apr 23, 2013 6:59:21 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 deleted
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r149013 r149015 1 2013-04-23 Kent Tamura <tkent@chromium.org> 2 3 Remove TextFieldDecoration feature 4 https://bugs.webkit.org/show_bug.cgi?id=115068 5 6 Reviewed by Andreas Kling. 7 8 Only Chromium port used this feature. 9 10 * dom/Element.h: Remove isTextFieldDecoration. 11 * html/InputType.cpp: 12 (WebCore::InputType::destroyShadowSubtree): 13 Update a comment. 14 * html/TextFieldInputType.cpp: 15 (WebCore::TextFieldInputType::createShadowSubtree): 16 Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo. 17 * html/shadow/TextFieldDecorationElement.cpp: Removed. 18 * html/shadow/TextFieldDecorationElement.h: Removed. 19 * page/ChromeClient.h: 20 (ChromeClient): Remove willAddTextFieldDecorationsTo and 21 addTextFieldDecorationsTo 22 1 23 2013-04-23 Andreas Kling <akling@apple.com> 2 24 -
trunk/Source/WebCore/dom/Element.h
r148961 r149015 553 553 virtual bool isOutOfRange() const { return false; } 554 554 virtual bool isFrameElementBase() const { return false; } 555 virtual bool isTextFieldDecoration() const { return false; }556 555 557 556 virtual bool canContainRangeEndPoint() const { return true; } -
trunk/Source/WebCore/html/InputType.cpp
r146847 r149015 489 489 root->removeChildren(); 490 490 491 // It's ok to clear contents of all other ShadowRoots because they must have 492 // been created by TextFieldDecorationElement, and we don't allow adding 493 // AuthorShadowRoot to HTMLInputElement. 491 // It's ok to clear contents of all other ShadowRoots because we don't allow 492 // adding AuthorShadowRoot to HTMLInputElement. 494 493 while ((root = root->youngerShadowRoot())) { 495 494 #if ENABLE(SHADOW_DOM) -
trunk/Source/WebCore/html/TextFieldInputType.cpp
r148545 r149015 35 35 #include "BeforeTextInsertedEvent.h" 36 36 #include "Chrome.h" 37 #include "ChromeClient.h"38 37 #include "Editor.h" 39 38 #include "ElementShadow.h" … … 234 233 235 234 Document* document = element()->document(); 236 ChromeClient* chromeClient = document->page() ? document->page()->chrome()->client() : 0;237 bool shouldAddDecorations = chromeClient && chromeClient->willAddTextFieldDecorationsTo(element());238 235 bool shouldHaveSpinButton = this->shouldHaveSpinButton(); 239 bool createsContainer = shouldHaveSpinButton || needsContainer() || shouldAddDecorations;236 bool createsContainer = shouldHaveSpinButton || needsContainer(); 240 237 241 238 m_innerText = TextControlInnerTextElement::create(document); … … 266 263 m_container->appendChild(m_innerSpinButton, IGNORE_EXCEPTION); 267 264 } 268 269 if (shouldAddDecorations)270 chromeClient->addTextFieldDecorationsTo(element());271 265 } 272 266 -
trunk/Source/WebCore/page/ChromeClient.h
r147357 r149015 340 340 virtual void resetPagePopupDriver() = 0; 341 341 #endif 342 // This function is called whenever a text field <input> is created. The343 // implementation should return true if it wants to do something in344 // addTextFieldDecorationsTo().345 // The argument is always non-0.346 virtual bool willAddTextFieldDecorationsTo(HTMLInputElement*) { return false; }347 // The argument is always non-0.348 virtual void addTextFieldDecorationsTo(HTMLInputElement*) { }349 350 342 virtual void postAccessibilityNotification(AccessibilityObject*, AXObjectCache::AXNotification) { } 351 343
Note: See TracChangeset
for help on using the changeset viewer.