Changeset 149015 in webkit


Ignore:
Timestamp:
Apr 23, 2013 6:59:21 PM (11 years ago)
Author:
tkent@chromium.org
Message:

Remove TextFieldDecoration feature
https://bugs.webkit.org/show_bug.cgi?id=115068

Reviewed by Andreas Kling.

Only Chromium port used this feature.

  • dom/Element.h: Remove isTextFieldDecoration.
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Update a comment.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.

  • html/shadow/TextFieldDecorationElement.cpp: Removed.
  • html/shadow/TextFieldDecorationElement.h: Removed.
  • page/ChromeClient.h:

(ChromeClient): Remove willAddTextFieldDecorationsTo and
addTextFieldDecorationsTo

Location:
trunk/Source/WebCore
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r149013 r149015  
     12013-04-23  Kent Tamura  <tkent@chromium.org>
     2
     3        Remove TextFieldDecoration feature
     4        https://bugs.webkit.org/show_bug.cgi?id=115068
     5
     6        Reviewed by Andreas Kling.
     7
     8        Only Chromium port used this feature.
     9
     10        * dom/Element.h: Remove isTextFieldDecoration.
     11        * html/InputType.cpp:
     12        (WebCore::InputType::destroyShadowSubtree):
     13        Update a comment.
     14        * html/TextFieldInputType.cpp:
     15        (WebCore::TextFieldInputType::createShadowSubtree):
     16        Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.
     17        * html/shadow/TextFieldDecorationElement.cpp: Removed.
     18        * html/shadow/TextFieldDecorationElement.h: Removed.
     19        * page/ChromeClient.h:
     20        (ChromeClient): Remove willAddTextFieldDecorationsTo and
     21        addTextFieldDecorationsTo
     22
    1232013-04-23  Andreas Kling  <akling@apple.com>
    224
  • trunk/Source/WebCore/dom/Element.h

    r148961 r149015  
    553553    virtual bool isOutOfRange() const { return false; }
    554554    virtual bool isFrameElementBase() const { return false; }
    555     virtual bool isTextFieldDecoration() const { return false; }
    556555
    557556    virtual bool canContainRangeEndPoint() const { return true; }
  • trunk/Source/WebCore/html/InputType.cpp

    r146847 r149015  
    489489    root->removeChildren();
    490490
    491     // It's ok to clear contents of all other ShadowRoots because they must have
    492     // been created by TextFieldDecorationElement, and we don't allow adding
    493     // AuthorShadowRoot to HTMLInputElement.
     491    // It's ok to clear contents of all other ShadowRoots because we don't allow
     492    // adding AuthorShadowRoot to HTMLInputElement.
    494493    while ((root = root->youngerShadowRoot())) {
    495494#if ENABLE(SHADOW_DOM)
  • trunk/Source/WebCore/html/TextFieldInputType.cpp

    r148545 r149015  
    3535#include "BeforeTextInsertedEvent.h"
    3636#include "Chrome.h"
    37 #include "ChromeClient.h"
    3837#include "Editor.h"
    3938#include "ElementShadow.h"
     
    234233
    235234    Document* document = element()->document();
    236     ChromeClient* chromeClient = document->page() ? document->page()->chrome()->client() : 0;
    237     bool shouldAddDecorations = chromeClient && chromeClient->willAddTextFieldDecorationsTo(element());
    238235    bool shouldHaveSpinButton = this->shouldHaveSpinButton();
    239     bool createsContainer = shouldHaveSpinButton || needsContainer() || shouldAddDecorations;
     236    bool createsContainer = shouldHaveSpinButton || needsContainer();
    240237
    241238    m_innerText = TextControlInnerTextElement::create(document);
     
    266263        m_container->appendChild(m_innerSpinButton, IGNORE_EXCEPTION);
    267264    }
    268 
    269     if (shouldAddDecorations)
    270         chromeClient->addTextFieldDecorationsTo(element());
    271265}
    272266
  • trunk/Source/WebCore/page/ChromeClient.h

    r147357 r149015  
    340340    virtual void resetPagePopupDriver() = 0;
    341341#endif
    342     // This function is called whenever a text field <input> is created. The
    343     // implementation should return true if it wants to do something in
    344     // addTextFieldDecorationsTo().
    345     // The argument is always non-0.
    346     virtual bool willAddTextFieldDecorationsTo(HTMLInputElement*) { return false; }
    347     // The argument is always non-0.
    348     virtual void addTextFieldDecorationsTo(HTMLInputElement*) { }
    349 
    350342    virtual void postAccessibilityNotification(AccessibilityObject*, AXObjectCache::AXNotification) { }
    351343
Note: See TracChangeset for help on using the changeset viewer.