Changeset 149362 in webkit


Ignore:
Timestamp:
Apr 30, 2013 6:17:19 AM (11 years ago)
Author:
Christophe Dumez
Message:

[EFL] Enable scaled cursors
https://bugs.webkit.org/show_bug.cgi?id=106242

Reviewed by Gyuyoung Kim.

.:

Enable MOUSE_CURSOR_SCALE flag for EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Correctly copy WebCore::Cursor's m_imageScaleFactor
member in CursorEfl.cpp when MOUSE_CURSOR_SCALE is
enabled.

No new tests, already covered by existing tests.

  • platform/efl/CursorEfl.cpp:

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):

Tools:

Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip fast/css/cursor-parsing-image-set.html for EFL port
now that scaled cursors are enabled. Update expectation for
fast/events/mouse-cursor-image-set.html to explain the
reason why it is failing and set its bug URL.

  • platform/efl/TestExpectations:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r149352 r149362  
     12013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        [EFL] Enable scaled cursors
     4        https://bugs.webkit.org/show_bug.cgi?id=106242
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Enable MOUSE_CURSOR_SCALE flag for EFL port.
     9
     10        * Source/cmake/OptionsEfl.cmake:
     11        * Source/cmake/WebKitFeatures.cmake:
     12
    1132013-04-29  Zan Dobersek  <zdobersek@igalia.com>
    214
  • trunk/LayoutTests/ChangeLog

    r149361 r149362  
     12013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        [EFL] Enable scaled cursors
     4        https://bugs.webkit.org/show_bug.cgi?id=106242
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Unskip fast/css/cursor-parsing-image-set.html for EFL port
     9        now that scaled cursors are enabled. Update expectation for
     10        fast/events/mouse-cursor-image-set.html to explain the
     11        reason why it is failing and set its bug URL.
     12
     13        * platform/efl/TestExpectations:
     14
    1152013-04-30  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
    216
  • trunk/LayoutTests/platform/efl/TestExpectations

    r149024 r149362  
    5959fast/dom/Window/slow-unload-handler.html
    6060fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
    61 
    62 # Need ENABLE(MOUSE_CURSOR_SCALE)
    63 fast/css/cursor-parsing-image-set.html
    64 fast/events/mouse-cursor-image-set.html
    6561
    6662# ----------------------------------------
     
    529525webkit.org/b/95182 fast/css/sticky/inline-sticky-abspos-child.html [ ImageOnlyFailure ]
    530526webkit.org/b/95182 fast/css/sticky/inline-sticky.html [ ImageOnlyFailure ]
     527
     528# Test is failing due to a scrolling problem on second iteration.
     529webkit.org/b/106240 fast/events/mouse-cursor-image-set.html [ Failure ]
    531530
    532531# Testcase assumes a thumb width of 12px, default there uses 29px.
  • trunk/Source/WebCore/ChangeLog

    r149360 r149362  
     12013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        [EFL] Enable scaled cursors
     4        https://bugs.webkit.org/show_bug.cgi?id=106242
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Correctly copy WebCore::Cursor's m_imageScaleFactor
     9        member in CursorEfl.cpp when MOUSE_CURSOR_SCALE is
     10        enabled.
     11
     12        No new tests, already covered by existing tests.
     13
     14        * platform/efl/CursorEfl.cpp:
     15        (WebCore::Cursor::Cursor):
     16        (WebCore::Cursor::operator=):
     17
    1182013-04-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    219
  • trunk/Source/WebCore/platform/efl/CursorEfl.cpp

    r147293 r149362  
    4545    , m_image(other.m_image)
    4646    , m_hotSpot(other.m_hotSpot)
     47#if ENABLE(MOUSE_CURSOR_SCALE)
     48    , m_imageScaleFactor(other.m_imageScaleFactor)
     49#endif
    4750    , m_platformCursor(other.m_platformCursor)
    4851{
     
    5861    m_image = other.m_image;
    5962    m_hotSpot = other.m_hotSpot;
     63#if ENABLE(MOUSE_CURSOR_SCALE)
     64    m_imageScaleFactor = other.m_imageScaleFactor;
     65#endif
    6066    m_platformCursor = other.m_platformCursor;
     67
    6168    return *this;
    6269}
  • trunk/Source/cmake/OptionsEfl.cmake

    r148718 r149362  
    8282WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML ON)
    8383WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MICRODATA ON)
     84WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MOUSE_CURSOR_SCALE ON)
    8485WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS ON)
    8586WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API ON)
  • trunk/Source/cmake/WebKitFeatures.cmake

    r147998 r149362  
    9090    WEBKIT_OPTION_DEFINE(ENABLE_MHTML "Toggle MHTML support" OFF)
    9191    WEBKIT_OPTION_DEFINE(ENABLE_MICRODATA "Toggle Microdata support" OFF)
    92     WEBKIT_OPTION_DEFINE(ENABLE_ENABLE_MOUSE_CURSOR_SCALE "Toggle Scaled mouse cursor support" OFF)
     92    WEBKIT_OPTION_DEFINE(ENABLE_MOUSE_CURSOR_SCALE "Toggle Scaled mouse cursor support" OFF)
    9393    WEBKIT_OPTION_DEFINE(ENABLE_NAVIGATOR_CONTENT_UTILS "Toggle Navigator Content Utils support" OFF)
    9494    WEBKIT_OPTION_DEFINE(ENABLE_NOSNIFF "Toggle support for 'X-Content-Type-Options: nosniff'" OFF)
  • trunk/Tools/ChangeLog

    r149356 r149362  
     12013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        [EFL] Enable scaled cursors
     4        https://bugs.webkit.org/show_bug.cgi?id=106242
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
     9
     10        * Scripts/webkitperl/FeatureList.pm:
     11
    1122013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    213
  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r149352 r149362  
    360360
    361361    { option => "mouse-cursor-scale", desc => "Toggle Scaled mouse cursor support",
    362       define => "ENABLE_MOUSE_CURSOR_SCALE", default => 0, value => \$mouseCursorScaleSupport },
     362      define => "ENABLE_MOUSE_CURSOR_SCALE", default => isEfl(), value => \$mouseCursorScaleSupport },
    363363
    364364    { option => "navigator-content-utils", desc => "Toggle Navigator Content Utils support",
Note: See TracChangeset for help on using the changeset viewer.