Changeset 149555 in webkit

Timestamp:

May 4, 2013 12:54:40 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Catch select.error exceptions in parse_output_lines
​https://bugs.webkit.org/show_bug.cgi?id=115253

Reviewed by Gustavo Noronha Silva.

Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
error code and the error message) and the loop is re-entered.

• gtk/common.py:

(parse_output_lines):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• gtk/common.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK] Catch select.error exceptions in parse_output_lines
+        https://bugs.webkit.org/show_bug.cgi?id=115253
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
+        output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
+        builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
+        error code and the error message) and the loop is re-entered.
+
+        * gtk/common.py:
+        (parse_output_lines):
+
 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Tools/gtk/common.py

@@ -115 +115 @@
     read_set = [fd]
     while read_set:
-        rlist, wlist, xlist = select.select(read_set, [], [])
+        try:
+            rlist, wlist, xlist = select.select(read_set, [], [])
+        except select.error as e:
+            parse_line_callback("WARNING: error while waiting for fd %d to become readable\n" % fd)
+            parse_line_callback("    error code: %d, error message: %s\n" % (e[0], e[1]))
+            continue
 
         if fd in rlist: