Changeset 149623 in webkit


Ignore:
Timestamp:
May 6, 2013 12:11:58 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[CSS Exclusions] remove unused -webkit-wrap property
​https://bugs.webkit.org/show_bug.cgi?id=102105

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-06
Reviewed by Darin Adler.

Source/WebCore:

Remove -webkit-wrap property and all mentions. This property doesn't
exist in the spec anymore, and was never implemented more than just
parsing the property.

  • WebCore.order:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Delete tests for the -webkit-wrap property.

  • fast/exclusions/css-exclusions-disabled.html: Remove use of -webkit-wrap.
  • fast/exclusions/script-tests/wrap-parsing.js: Removed.
  • fast/exclusions/wrap-parsing-expected.txt: Removed.
  • fast/exclusions/wrap-parsing.html: Removed.
  • svg/css/style-change-crash-expected.txt: Removed.
  • svg/css/style-change-crash.html: Removed.
Location:
trunk
Files:
5 deleted
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r149616 r149623  
     12013-05-06  Bem Jones-Bey  <bjonesbe@adobe.com>
     2
     3        [CSS Exclusions] remove unused -webkit-wrap property
     4        https://bugs.webkit.org/show_bug.cgi?id=102105
     5
     6        Reviewed by Darin Adler.
     7
     8        Delete tests for the -webkit-wrap property.
     9
     10        * fast/exclusions/css-exclusions-disabled.html: Remove use of -webkit-wrap.
     11        * fast/exclusions/script-tests/wrap-parsing.js: Removed.
     12        * fast/exclusions/wrap-parsing-expected.txt: Removed.
     13        * fast/exclusions/wrap-parsing.html: Removed.
     14        * svg/css/style-change-crash-expected.txt: Removed.
     15        * svg/css/style-change-crash.html: Removed.
     16
    1172013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    218

  • trunk/LayoutTests/fast/exclusions/css-exclusions-disabled.html

    r142893 r149623  
    3737testStyle("-webkit-wrap-through", "none", "wrap");
    3838
    39 testInlineStyle("-webkit-wrap", "both 10px 10px");
    40 
    4139testStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)", "auto");
    4240testStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)", "outside-shape");

  • trunk/Source/WebCore/ChangeLog

    r149615 r149623  
     12013-05-06  Bem Jones-Bey  <bjonesbe@adobe.com>
     2
     3        [CSS Exclusions] remove unused -webkit-wrap property
     4        https://bugs.webkit.org/show_bug.cgi?id=102105
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove -webkit-wrap property and all mentions. This property doesn't
     9        exist in the spec anymore, and was never implemented more than just
     10        parsing the property.
     11
     12        * WebCore.order:
     13        * css/CSSComputedStyleDeclaration.cpp:
     14        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
     15        * css/CSSParser.cpp:
     16        (WebCore::CSSParser::parseValue):
     17        * css/CSSProperty.cpp:
     18        (WebCore::CSSProperty::isInheritedProperty):
     19        * css/CSSPropertyNames.in:
     20        * css/StylePropertySet.cpp:
     21        (WebCore::StylePropertySet::getPropertyValue):
     22        (WebCore::StylePropertySet::asText):
     23        * css/StylePropertyShorthand.cpp:
     24        (WebCore::shorthandForProperty):
     25        * css/StylePropertyShorthand.h:
     26        (WebCore):
     27        * css/StyleResolver.cpp:
     28        (WebCore::StyleResolver::applyProperty):
     29
    1302013-05-06  Anders Carlsson  <andersca@apple.com>
    231

  • trunk/Source/WebCore/WebCore.order

    r149432 r149623  
    3972439724__ZZN7WebCore25webkitMaskRepeatShorthandEvE25webkitMaskRepeatLonghands
    3972539725__ZGVZN7WebCore25webkitMaskRepeatShorthandEvE25webkitMaskRepeatLonghands.b
    39726 __ZZN7WebCore19webkitWrapShorthandEvE19webkitWrapLonghands
    39727 __ZGVZN7WebCore19webkitWrapShorthandEvE19webkitWrapLonghands.b
    3972839726__ZN7WebCoreL22defaultViewSourceStyleE
    3972939727__ZZN7WebCore13StyleResolver26keyframeStylesForAnimationEPNS_7ElementEPKNS_11RenderStyleERNS_12KeyframeListEE19zeroPercentKeyframe

  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r148921 r149623  
    28422842        case CSSPropertyWebkitTransformOriginY:
    28432843        case CSSPropertyWebkitTransformOriginZ:
    2844 #if ENABLE(CSS_EXCLUSIONS)
    2845         case CSSPropertyWebkitWrap:
    2846 #endif
    28472844#if ENABLE(CSS_SHADERS)
    28482845        case CSSPropertyMix:

  • trunk/Source/WebCore/css/CSSParser.cpp

    r149360 r149623  
    29772977        validPrimitive = (RuntimeEnabledFeatures::cssExclusionsEnabled() && !id && validUnit(value, FLength | FNonNeg));
    29782978        break;
    2979     case CSSPropertyWebkitWrap:
    2980         return RuntimeEnabledFeatures::cssExclusionsEnabled() && parseShorthand(propId, webkitWrapShorthand(), important);
    29812979#endif
    29822980#if ENABLE(CSS_IMAGE_ORIENTATION)

  • trunk/Source/WebCore/css/CSSProperty.cpp

    r148921 r149623  
    671671#endif
    672672#if ENABLE(CSS_EXCLUSIONS)
    673     case CSSPropertyWebkitWrap:
    674673    case CSSPropertyWebkitWrapFlow:
    675674    case CSSPropertyWebkitShapeMargin:

  • trunk/Source/WebCore/css/CSSPropertyNames.in

    r148227 r149623  
    428428-webkit-wrap-flow
    429429-webkit-wrap-through
    430 -webkit-wrap
    431430#endif
    432431#if defined(ENABLE_CSS_DEVICE_ADAPTATION) && ENABLE_CSS_DEVICE_ADAPTATION

  • trunk/Source/WebCore/css/StylePropertySet.cpp

    r149529 r149623  
    205205    case CSSPropertyWebkitAnimation:
    206206        return getLayeredShorthandValue(webkitAnimationShorthand());
    207 #if ENABLE(CSS_EXCLUSIONS)
    208     case CSSPropertyWebkitWrap:
    209         return getShorthandValue(webkitWrapShorthand());
    210 #endif
    211207#if ENABLE(SVG)
    212208    case CSSPropertyMarker: {
    … …  
    920916            shorthandPropertyID = CSSPropertyWebkitTransition;
    921917            break;
    922 #if ENABLE(CSS_EXCLUSIONS)
    923         case CSSPropertyWebkitWrapFlow:
    924         case CSSPropertyWebkitShapeMargin:
    925         case CSSPropertyWebkitShapePadding:
    926             shorthandPropertyID = CSSPropertyWebkitWrap;
    927             break;
    928 #endif
    929918        default:
    930919            break;

  • trunk/Source/WebCore/css/StylePropertyShorthand.cpp

    r145172 r149623  
    470470    return webkitTransformOriginLonghands;
    471471}
    472 
    473 #if ENABLE(CSS_EXCLUSIONS)
    474 const StylePropertyShorthand& webkitWrapShorthand()
    475 {
    476     static const CSSPropertyID webkitWrapProperties[] = {
    477         CSSPropertyWebkitWrapFlow,
    478         CSSPropertyWebkitShapeMargin,
    479         CSSPropertyWebkitShapePadding
    480     };
    481     DEFINE_STATIC_LOCAL(StylePropertyShorthand, webkitWrapLonghands, (webkitWrapProperties, WTF_ARRAY_LENGTH(webkitWrapProperties)));
    482     return webkitWrapLonghands;
    483 }
    484 #endif
    485472
    486473// Returns an empty list if the property is not a shorthand
    … …  
    572559    case CSSPropertyWebkitTransformOrigin:
    573560        return webkitTransformOriginShorthand();
    574 #if ENABLE(CSS_EXCLUSIONS)
    575     case CSSPropertyWebkitWrap:
    576         return webkitWrapShorthand();
    577 #endif
    578561    default: {
    579562        DEFINE_STATIC_LOCAL(StylePropertyShorthand, emptyShorthand, ());

  • trunk/Source/WebCore/css/StylePropertyShorthand.h

    r145029 r149623  
    103103const StylePropertyShorthand& webkitTransitionShorthand();
    104104const StylePropertyShorthand& webkitTransformOriginShorthand();
    105 #if ENABLE(CSS_EXCLUSIONS)
    106 const StylePropertyShorthand& webkitWrapShorthand();
    107 #endif
    108105
    109106// Returns an empty list if the property is not a shorthand

  • trunk/Source/WebCore/css/StyleResolver.cpp

    r149579 r149623  
    24742474    case CSSPropertyWebkitTransition:
    24752475    case CSSPropertyWebkitTransformOrigin:
    2476 #if ENABLE(CSS_EXCLUSIONS)
    2477     case CSSPropertyWebkitWrap:
    2478 #endif
    24792476        ASSERT(isExpandedShorthand(id));
    24802477        ASSERT_NOT_REACHED();
Note: See TracChangeset for help on using the changeset viewer.