Changeset 149672 in webkit

Timestamp:

May 7, 2013 8:53:34 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Curl] POST requests sometimes fail.
​https://bugs.webkit.org/show_bug.cgi?id=111844

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-07
Reviewed by Brent Fulgham.

Curl adds the header 'Expect: 100-Continue' when sending a POST request.
When we receive the header 'HTTP/1.1 100 Continue', we should not call
ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
because the MIME type is empty in this case, causing the POST request to fail.
This header is only sent as an info header, or provisional response.

In addition, this patch changes the classification of http code 304 (Not modified).
It is not reported as a redirect anymore, but as a response
(ResourceHandleClient::didReceiveResponse() is called.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::isHttpInfo): Added helper method to determine if http code is http info.
(WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
(WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/ResourceHandleManager.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-07  peavo@outlook.com  <peavo@outlook.com>
+
+        [Curl] POST requests sometimes fail.
+        https://bugs.webkit.org/show_bug.cgi?id=111844
+
+        Reviewed by Brent Fulgham.
+
+        Curl adds the header 'Expect: 100-Continue' when sending a POST request.
+        When we receive the header 'HTTP/1.1 100 Continue', we should not call
+        ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
+        because the MIME type is empty in this case, causing the POST request to fail.
+        This header is only sent as an info header, or provisional response.
+        
+        In addition, this patch changes the classification of http code 304 (Not modified).
+        It is not reported as a redirect anymore, but as a response
+        (ResourceHandleClient::didReceiveResponse() is called.
+
+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::isHttpInfo): Added helper method to determine if http code is http info.
+        (WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
+        (WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.
+
 2013-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp

@@ -127 +127 @@
 }
 
+inline static bool isHttpInfo(int statusCode)
+{
+    return 100 <= statusCode && statusCode < 200;
+}
+
+inline static bool isHttpRedirect(int statusCode)
+{
+    return 300 <= statusCode && statusCode < 400 && statusCode != 304;
+}
+
 ResourceHandleManager::ResourceHandleManager()
     : m_downloadTimer(this, &ResourceHandleManager::downloadTimerCallback)
@@ -265 +275 @@
         CURLcode err;
 
+        long httpCode = 0;
+        err = curl_easy_getinfo(h, CURLINFO_RESPONSE_CODE, &httpCode);
+
+        if (isHttpInfo(httpCode)) {
+            // Just return when receiving http info, e.g. HTTP/1.1 100 Continue.
+            // If not, the request might be cancelled, because the MIME type will be empty for this response.
+            return totalSize;
+        }
+
         double contentLength = 0;
         err = curl_easy_getinfo(h, CURLINFO_CONTENT_LENGTH_DOWNLOAD, &contentLength);
@@ -273 +292 @@
         d->m_response.setURL(KURL(ParsedURLString, hdr));
 
-        long httpCode = 0;
-        err = curl_easy_getinfo(h, CURLINFO_RESPONSE_CODE, &httpCode);
         d->m_response.setHTTPStatusCode(httpCode);
-
         d->m_response.setMimeType(extractMIMETypeFromMediaType(d->m_response.httpHeaderField("Content-Type")));
         d->m_response.setTextEncodingName(extractCharsetFromMediaType(d->m_response.httpHeaderField("Content-Type")));
@@ -282 +298 @@
 
         // HTTP redirection
-        if (httpCode >= 300 && httpCode < 400) {
+        if (isHttpRedirect(httpCode)) {
             String location = d->m_response.httpHeaderField("location");
             if (!location.isEmpty()) {