Changeset 149800 in webkit

Timestamp:

May 9, 2013 6:11:30 AM (11 years ago)

Author:

akling@apple.com

Message:

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<​http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

Location:

trunk/Source/WebKit/qt

Files:

• Api/qwebelement.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/qt/Api/qwebelement.cpp

@@ -837 +837 @@
         Vector<RefPtr<StyleRuleBase> > rules = doc->ensureStyleResolver()->styleRulesForElement(m_element, StyleResolver::AuthorCSSRules | StyleResolver::CrossOriginCSSRules);
         for (int i = rules.size(); i > 0; --i) {
-            if (!rules[i]->isStyleRule())
+            if (!rules[i - 1]->isStyleRule())
                 continue;
             StyleRule* styleRule = static_cast<StyleRule*>(rules[i - 1].get());

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2013-05-09  Andreas Kling  <akling@apple.com>
+
+        [Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
+        <http://webkit.org/b/115855>
+
+        Fix obvious off-by-one mistake.
+
+        * Api/qwebelement.cpp:
+        (QWebElement::styleProperty):
+
 2013-05-07  Allan Sandfeld Jensen  <allan.jensen@digia.com>