Changeset 149885 in webkit

Timestamp:

May 10, 2013 10:20:59 AM (11 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION (r149439): Video turns blank upon entering full screen for the first time
​https://bugs.webkit.org/show_bug.cgi?id=115617

Reviewed by Eric Carlson.

Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
first-full screen behavior.

• UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-05-10  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r149439): Video turns blank upon entering full screen for the first time
+        https://bugs.webkit.org/show_bug.cgi?id=115617
+
+        Reviewed by Eric Carlson.
+
+        Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
+        platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
+        first-full screen behavior.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView createFullScreenWindow]):
+
 2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -3395 +3395 @@
 {
 #if ENABLE(FULLSCREEN_API)
-    return [[[WebCoreFullScreenWindow alloc] initWithContentRect:[[NSScreen mainScreen] frame] styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1080
+    NSRect contentRect = NSZeroRect;
+#else
+    NSRect contentRect = [[NSScreen mainScreen] frame];
+#endif
+    return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
 #else
     return nil;