Changeset 149887 in webkit

Timestamp:

May 10, 2013 10:36:29 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Generated files are regenerated always
​https://bugs.webkit.org/show_bug.cgi?id=115908

Reviewed by Carlos Garcia Campos.

No new tests - no change in functionality.

• GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.

The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK] Generated files are regenerated always
+        https://bugs.webkit.org/show_bug.cgi?id=115908
+
+        Reviewed by Carlos Garcia Campos.
+
+        No new tests - no change in functionality.
+
+        * GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.
+        The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
+        the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
+        which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
+
 2013-05-10  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/GNUmakefile.am

@@ -426 +426 @@
 
 .SECONDARY:
-DerivedSources/WebCore/JS%.h: %.idl $(SCRIPTS_FOR_GENERATE_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorJS.pm $(supplemental_dependency_file) $(idl_attributes_file) $(window_constructors_file)
+DerivedSources/WebCore/JS%.h: %.idl $(SCRIPTS_FOR_GENERATE_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorJS.pm $(supplemental_dependency_file) $(idl_attributes_file)
         $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/generate-bindings.pl $(IDL_PATH:%=--include "%") --outputDir "$(GENSOURCES_WEBCORE)" --defines "LANGUAGE_JAVASCRIPT=1 $(feature_defines)" --generator JS --idlAttributesFile $(idl_attributes_file) --supplementalDependencyFile $(supplemental_dependency_file) $<