Changeset 150075 in webkit

Timestamp:

May 14, 2013 10:44:37 AM (11 years ago)

Author:

Antoine Quint

Message:

[Mac] captions menu is not positioned correctly in full-screen
​https://bugs.webkit.org/show_bug.cgi?id=116103

Update the positioning properties of the captions menu in full-screen
following the fix for ​https://webkit.org/b/115968.

Reviewed by Darin Adler.

• css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
Add 50px to the bottom position since we're now positioned relative to the
media element, and use a calc() command to be right-aligned to the captions
icon in the media controller. The max-width and max-height properties follow
the same technique used for the non-full-screen mode.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/fullscreenQuickTime.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-14  Antoine Quint  <graouts@apple.com>
+
+        [Mac] captions menu is not positioned correctly in full-screen
+        https://bugs.webkit.org/show_bug.cgi?id=116103
+
+        Update the positioning properties of the captions menu in full-screen
+        following the fix for https://webkit.org/b/115968.
+
+        Reviewed by Darin Adler.
+
+        * css/fullscreenQuickTime.css:
+        (video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
+        Add 50px to the bottom position since we're now positioned relative to the
+        media element, and use a calc() command to be right-aligned to the captions
+        icon in the media controller. The max-width and max-height properties follow
+        the same technique used for the non-full-screen mode.
+
 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/css/fullscreenQuickTime.css

@@ -169 +169 @@
 
 video:-webkit-full-screen::-webkit-media-controls-closed-captions-container {
-    bottom: 64px;
-    right: 38px;
+    bottom: 114px;
+    right: -webkit-calc(50% - 183px); /* 183px is 221px (half the media controller's width) minus 38px (the right position of the captions icon). */
+    max-width: -webkit-calc(50% + 173px); /* right + 10px */
+    max-height: -webkit-calc(100% - 124px); /* bottom + 10px */
 }
-
-video:-webkit-full-screen::-webkit-media-controls-closed-captions-track-list {
-    max-height: 500px;
-}