Changeset 150272 in webkit


Ignore:
Timestamp:
May 17, 2013 10:34:24 AM (11 years ago)
Author:
ddkilzer@apple.com
Message:

Make filter-build-webkit testable using LoadAsModule
Part 1 of 3: <http://webkit.org/b/116247>

Reviewed by Benjamin Poulain.

  • Scripts/filter-build-webkit: Change global variables that are

used in subroutines from 'my' to 'our' to make it possible to
evaluate the script in a package context in LoadAsModule.pm.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r150242 r150272  
     12013-05-17  David Kilzer  <ddkilzer@apple.com>
     2
     3        Make filter-build-webkit testable using LoadAsModule
     4        Part 1 of 3: <http://webkit.org/b/116247>
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * Scripts/filter-build-webkit: Change global variables that are
     9        used in subroutines from 'my' to 'our' to make it possible to
     10        evaluate the script in a package context in LoadAsModule.pm.
     11
    1122013-05-14  Sam Weinig  <sam@webkit.org>
    213
  • trunk/Tools/Scripts/filter-build-webkit

    r109975 r150272  
    11#!/usr/bin/perl -w
    22
    3 # Copyright (C) 2011 Apple Inc. All rights reserved.
     3# Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
    44#
    55# Redistribution and use in source and binary forms, with or without
     
    7272sub possiblyColored($$);
    7373
     74# Global variables used only in global scope.
     75my $outputPath = "&STDOUT";
    7476my $showHelp;
    75 my $outputPath = "&STDOUT";
    76 my $outputFormat = "text";
    77 my $useColor = -t STDOUT;
    78 my $unfilteredOutputPath = "build.log";
    79 my $logUnfilteredOutput;
     77
     78# Global variables used in global and subroutine scope.
     79our $logUnfilteredOutput;
     80our $outputFormat = "text";
     81our $unfilteredOutputPath = "build.log";
     82our $useColor = -t STDOUT;
    8083
    8184sub usageAndExit()
Note: See TracChangeset for help on using the changeset viewer.