Changeset 150311 in webkit


Ignore:
Timestamp:
May 17, 2013 5:16:19 PM (11 years ago)
Author:
Christophe Dumez
Message:

Get rid of Custom code for Audio global constructor
​https://bugs.webkit.org/show_bug.cgi?id=116343

Reviewed by Geoffrey Garen.

Remove custom code for Audio global constructor. It is no longer needed
now that the the bindings generator no longer require custom code for
named constructors and now that [EnabledAtRuntime] extended attribute is
supported for global constructors.

HTMLAudioElement global constructors are now automatically generated.

No new tests, no behavior change for layout tests.

  • bindings/js/JSDOMWindowCustom.cpp:
  • html/HTMLAudioElement.idl:
  • page/DOMWindow.idl:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r150310 r150311  
     12013-05-17  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Get rid of Custom code for Audio global constructor
     4        https://bugs.webkit.org/show_bug.cgi?id=116343
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Remove custom code for Audio global constructor. It is no longer needed
     9        now that the the bindings generator no longer require custom code for
     10        named constructors and now that [EnabledAtRuntime] extended attribute is
     11        supported for global constructors.
     12
     13        HTMLAudioElement global constructors are now automatically generated.
     14
     15        No new tests, no behavior change for layout tests.
     16
     17        * bindings/js/JSDOMWindowCustom.cpp:
     18        * html/HTMLAudioElement.idl:
     19        * page/DOMWindow.idl:
     20
    1212013-05-17  Alexey Proskuryakov  <ap@apple.com>
    222

  • trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp

    r150283 r150311  
    534534}
    535535
    536 #if ENABLE(VIDEO)
    537 JSValue JSDOMWindow::audio(ExecState* exec) const
    538 {
    539     if (!MediaPlayer::isAvailable())
    540         return jsUndefined();
    541     return getDOMConstructor<JSHTMLAudioElementNamedConstructor>(exec, this);
    542 }
    543 #endif
    544 
    545536// Custom functions
    546537

  • trunk/Source/WebCore/html/HTMLAudioElement.idl

    r149796 r150311  
    2525
    2626[
    27     NoInterfaceObject,
     27    EnabledAtRuntime,
    2828    Conditional=VIDEO,
    2929    NamedConstructor=Audio([Default=NullString] optional DOMString src)

  • trunk/Source/WebCore/page/DOMWindow.idl

    r150283 r150311  
    323323    // Additional constructors.
    324324    [CustomGetter, CustomConstructor] attribute HTMLImageElementNamedConstructor Image; // Usable with new operator
    325     [CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementNamedConstructor Audio; // Usable with the new operator
    326     [Conditional=VIDEO] attribute HTMLAudioElementConstructor HTMLAudioElement;
    327325    // Mozilla has a separate XMLDocument object for XML documents.
    328326    // We just use Document for this.
Note: See TracChangeset for help on using the changeset viewer.