Changeset 150316 in webkit

Timestamp:

May 17, 2013 7:28:25 PM (11 years ago)

Author:

akling@apple.com

Message:

Plug leak in CSSSelectorList::deleteSelectors().
<​http://webkit.org/b/116371>
<rdar://problem/13930698>

Reviewed by Ryosuke Niwa.

Don't forget to destroy the very last selector in the list.

• css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::deleteSelectors):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSSelectorList.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-17  Andreas Kling  <akling@apple.com>
+
+        Plug leak in CSSSelectorList::deleteSelectors().
+        <http://webkit.org/b/116371>
+        <rdar://problem/13930698>
+
+        Reviewed by Ryosuke Niwa.
+
+        Don't forget to destroy the very last selector in the list.
+
+        * css/CSSSelectorList.cpp:
+        (WebCore::CSSSelectorList::deleteSelectors):
+
 2013-05-17  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/css/CSSSelectorList.cpp

@@ -101 +101 @@
         return;
 
-    for (CSSSelector* s = m_selectorArray; !s->isLastInSelectorList(); ++s)
+    for (CSSSelector* s = m_selectorArray; ; ++s) {
         s->~CSSSelector();
+        if (s->isLastInSelectorList())
+            break;
+    }
     fastFree(m_selectorArray);
 }