Changeset 150318 in webkit

Timestamp:

May 17, 2013 7:56:20 PM (11 years ago)

Author:

akling@apple.com

Message:

Ads on theverge.com cause repaints when hovered, even though content doesn't visibly change.
<​http://webkit.org/b/116344>

Reviewed by Darin Adler.

Teach RenderStyle::diff() to ignore differences in the outline value if both styles have non-visible outlines.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

• rendering/style/StyleBackgroundData.cpp:

(WebCore::StyleBackgroundData::isEquivalentForPainting):

• rendering/style/StyleBackgroundData.h:

(StyleBackgroundData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/RenderStyle.cpp (modified) (1 diff)
• rendering/style/StyleBackgroundData.cpp (modified) (1 diff)
• rendering/style/StyleBackgroundData.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-17  Andreas Kling  <akling@apple.com>
+
+        Ads on theverge.com cause repaints when hovered, even though content doesn't visibly change.
+        <http://webkit.org/b/116344>
+
+        Reviewed by Darin Adler.
+
+        Teach RenderStyle::diff() to ignore differences in the outline value if both styles have non-visible outlines.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::diff):
+        * rendering/style/StyleBackgroundData.cpp:
+        (WebCore::StyleBackgroundData::isEquivalentForPainting):
+        * rendering/style/StyleBackgroundData.h:
+        (StyleBackgroundData):
+
 2013-05-17  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -680 +680 @@
         || inherited_flags._insideLink != other->inherited_flags._insideLink
         || surround->border != other->surround->border
-        || *m_background.get() != *other->m_background.get()
+        || !m_background->isEquivalentForPainting(*other->m_background)
         || rareInheritedData->userModify != other->rareInheritedData->userModify
         || rareInheritedData->userSelect != other->rareInheritedData->userSelect

trunk/Source/WebCore/rendering/style/StyleBackgroundData.cpp

@@ -47 +47 @@
 }
 
+bool StyleBackgroundData::isEquivalentForPainting(const StyleBackgroundData& other) const
+{
+    if (m_background != other.m_background || m_color != other.m_color)
+        return false;
+    if (!m_outline.isVisible() && !other.m_outline.isVisible())
+        return true;
+    return m_outline == other.m_outline;
+}
+
 } // namespace WebCore

trunk/Source/WebCore/rendering/style/StyleBackgroundData.h

@@ -46 +46 @@
     }
 
+    bool isEquivalentForPainting(const StyleBackgroundData&) const;
+
     const FillLayer& background() const { return m_background; }
     const Color& color() const { return m_color; }