Changeset 150585 in webkit

Timestamp:

May 23, 2013 7:14:52 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
​https://bugs.webkit.org/show_bug.cgi?id=116603

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-23
Reviewed by Xan Lopez.

PR 119789
Internally reviewed by Yong Li.

Provide a domain value for this ResourceError instance. Note that
this does not change behavior.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/FrameLoaderClientBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-05-23  Rob Buis  <rbuis@rim.com>
+
+        [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
+        https://bugs.webkit.org/show_bug.cgi?id=116603
+
+        Reviewed by Xan Lopez.
+
+        PR 119789
+        Internally reviewed by Yong Li.
+
+        Provide a domain value for this ResourceError instance. Note that
+        this does not change behavior.
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
+
 2013-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp

@@ -1308 +1308 @@
 ResourceError FrameLoaderClientBlackBerry::cannotShowURLError(const ResourceRequest& request)
 {
-    // FIXME: Why are we not passing the domain to the ResourceError? See PR #119789.
-    return ResourceError(String(), WebKitErrorCannotShowURL, request.url().string(), String());
+    return ResourceError("WebKitErrorDomain", WebKitErrorCannotShowURL, request.url().string(), String());
 }