Changeset 150603 in webkit

Timestamp:

May 23, 2013 12:19:10 PM (11 years ago)

Author:

Patrick Gansterer

Message:

Use correct stack size on Solaris and OpenBSD
​https://bugs.webkit.org/show_bug.cgi?id=114978

Reviewed by Oliver Hunt.

Original patch by David Hill <​david@wmol.com>.

Use stack_t.ss_size for getting the size of the stack.

• wtf/Platform.h:
• wtf/StackBounds.cpp:

(WTF):
(WTF::StackBounds::initialize):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Platform.h (modified) (1 diff)
• wtf/StackBounds.cpp (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-05-23 Patrick Gansterer <paroga@webkit.org>
+
+        Use correct stack size on Solaris and OpenBSD
+        https://bugs.webkit.org/show_bug.cgi?id=114978
+
+        Reviewed by Oliver Hunt.
+
+        Original patch by David Hill <david@wmol.com>.
+
+        Use stack_t.ss_size for getting the size of the stack.
+
+        * wtf/Platform.h:
+        * wtf/StackBounds.cpp:
+        (WTF):
+        (WTF::StackBounds::initialize):
+
 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WTF/wtf/Platform.h

@@ -66 +66 @@
 #endif
 
+/* CPU(HPPA) - HP PA-RISC */
+#if defined(__hppa__) || defined(__hppa64__)
+#define WTF_CPU_HPPA 1
+#endif
+
 /* CPU(IA64) - Itanium / IA-64 */
 #if defined(__ia64__)

trunk/Source/WTF/wtf/StackBounds.cpp

@@ -56 +56 @@
 namespace WTF {
 
-// Bug 26276 - Need a mechanism to determine stack extent
-//
-// These platforms should now be working correctly:
-//     DARWIN, QNX, UNIX, WINDOWS
-// These platforms are not:
-//     SOLARIS, OPENBSD
-//
-// FIXME: remove this! - this code unsafely guesses at stack sizes!
-#if OS(SOLARIS) || OS(OPENBSD)
-// Based on the current limit used by the JSC parser, guess the stack size.
-static const ptrdiff_t estimatedStackSize = 128 * sizeof(void*) * 1024;
-// This method assumes the stack is growing downwards.
-static void* estimateStackBound(void* origin)
-{
-    return static_cast<char*>(origin) - estimatedStackSize;
-}
-#endif
-
 #if OS(DARWIN)
 
@@ -125 +107 @@
     thr_stksegment(&s);
     m_origin = s.ss_sp;
-    m_bound = estimateStackBound(m_origin);
+    m_bound = static_cast<char*>(m_origin) - s.ss_size;
 }
 
@@ -136 +118 @@
     pthread_stackseg_np(thread, &stack);
     m_origin = stack.ss_sp;
-    m_bound = estimateStackBound(m_origin);
+#if CPU(HPPA)
+    m_bound = static_cast<char*>(m_origin) + stack.ss_size;
+#else
+    m_bound = static_cast<char*>(m_origin) - stack.ss_size;
+#endif
 }