Changeset 150663 in webkit


Ignore:
Timestamp:
May 24, 2013 3:57:29 PM (11 years ago)
Author:
Christophe Dumez
Message:

Remove custom code for webkitAudioContext global constructor getter
https://bugs.webkit.org/show_bug.cgi?id=116530

Reviewed by Geoffrey Garen.

Source/WebCore:

Get rid of custom code for webkitAudioContext global constructor getter. The
global DOMWindow attribute is now automatically generated by leveraging support
for [EnabledAtRuntime] extended attribute and the existing methods in
RuntimeEnabledFeatures class.

No new tests, no behavior change.

  • GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
  • Modules/webaudio/AudioContext.idl:

Remove [NoInterfaceObject] extended attribute so that the global constructor is
automatically generated instead of automatically added. Add [EnabledAtRuntime]
extended attribute since this global constructor can be disabled at runtime and
so that we can getter rid of the [CustomGetter] for the corresponding global
constructor. Use [InterfaceName] extended attribute so that the interface name
matches the global constructor on DOMWindow (webkitAudioContext).

  • Target.pri: Remove JSDOMWindowWebAudioCustom.*.
  • UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.exp.in: Export additional symbol.
  • WebCore.order: Export additional symbol.
  • WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):

  • bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
  • bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for

the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
bindings generator now.

  • page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically

generated.

  • page/Settings.in: Remove webAudioEnabled setting as we use the existing setting

in RuntimeEnabledFeatures now.

Source/WebKit/efl:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setWebAudioEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

  • ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer

a view specific feature.

Source/WebKit/gtk:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
WebAudio feature instead of public ewk_view API since that API was
removed.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

Location:
trunk
Files:
1 deleted
34 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r150656 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Get rid of custom code for webkitAudioContext global constructor getter. The
     9        global DOMWindow attribute is now automatically generated by leveraging support
     10        for [EnabledAtRuntime] extended attribute and the existing methods in
     11        RuntimeEnabledFeatures class.
     12
     13        No new tests, no behavior change.
     14
     15        * GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
     16        * Modules/webaudio/AudioContext.idl:
     17        Remove [NoInterfaceObject] extended attribute so that the global constructor is
     18        automatically generated instead of automatically added. Add [EnabledAtRuntime]
     19        extended attribute since this global constructor can be disabled at runtime and
     20        so that we can getter rid of the [CustomGetter] for the corresponding global
     21        constructor. Use [InterfaceName] extended attribute so that the interface name
     22        matches the global constructor on DOMWindow (webkitAudioContext).
     23
     24        * Target.pri: Remove JSDOMWindowWebAudioCustom.*.
     25        * UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
     26        * WebCore.exp.in: Export additional symbol.
     27        * WebCore.order: Export additional symbol.
     28        * WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
     29        * WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
     30        * WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
     31        * WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
     32        * bindings/generic/RuntimeEnabledFeatures.h:
     33        (WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):
     34        * bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
     35        * bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for
     36        the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
     37        bindings generator now.
     38        * page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically
     39        generated.
     40        * page/Settings.in: Remove webAudioEnabled setting as we use the existing setting
     41        in RuntimeEnabledFeatures now.
     42
    1432013-05-24  Seokju Kwon  <seokju.kwon@gmail.com>
    244
  • trunk/Source/WebCore/GNUmakefile.list.am

    r150652 r150663  
    23942394        Source/WebCore/bindings/js/JSDOMWindowShell.cpp \
    23952395        Source/WebCore/bindings/js/JSDOMWindowShell.h \
    2396         Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp \
    23972396        Source/WebCore/bindings/js/JSDOMWrapper.cpp \
    23982397        Source/WebCore/bindings/js/JSDOMWrapper.h \
  • trunk/Source/WebCore/Modules/webaudio/AudioContext.idl

    r150292 r150663  
    2525
    2626[
    27     NoInterfaceObject,
     27    EnabledAtRuntime,
    2828    Conditional=WEB_AUDIO,
    2929    ActiveDOMObject,
    3030    CustomConstructor,
    31     EventTarget
     31    EventTarget,
     32    InterfaceName=webkitAudioContext
    3233] interface AudioContext {
    3334    // All rendered audio ultimately connects to destination, which represents the audio hardware.
  • trunk/Source/WebCore/Target.pri

    r150356 r150663  
    114114     bindings/js/JSDOMWindowCustom.cpp \
    115115     bindings/js/JSDOMWindowShell.cpp \
    116      bindings/js/JSDOMWindowWebAudioCustom.cpp \
    117116     bindings/js/JSDOMWrapper.cpp \
    118117     bindings/js/JSDataViewCustom.cpp \
     
    34813480        bindings/js/JSAudioContextCustom.cpp \
    34823481        bindings/js/JSBiquadFilterNodeCustom.cpp \
    3483         bindings/js/JSDOMWindowWebAudioCustom.cpp \
    34843482        bindings/js/JSOscillatorNodeCustom.cpp \
    34853483        bindings/js/JSPannerNodeCustom.cpp \
  • trunk/Source/WebCore/UseJSC.cmake

    r150276 r150663  
    6666    bindings/js/JSDOMWindowCustom.cpp
    6767    bindings/js/JSDOMWindowShell.cpp
    68     bindings/js/JSDOMWindowWebAudioCustom.cpp
    6968    bindings/js/JSDOMWrapper.cpp
    7069    bindings/js/JSDeviceMotionEventCustom.cpp
  • trunk/Source/WebCore/WebCore.exp.in

    r150653 r150663  
    26762676#endif
    26772677
     2678#if ENABLE(WEB_AUDIO)
     2679__ZN7WebCore22RuntimeEnabledFeatures17isWebAudioEnabledE
     2680#endif
     2681
    26782682#if ENABLE(DIALOG_ELEMENT)
    26792683__ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE
  • trunk/Source/WebCore/WebCore.order

    r150045 r150663  
    4081940819__ZN7WebCore23RenderSVGResourceMasker14s_resourceTypeE
    4082040820__ZN7WebCore15ResourceRequest23s_httpPipeliningEnabledE
     40821__ZN7WebCore22RuntimeEnabledFeatures17isWebAudioEnabledE
    4082140822__ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE
    4082240823__ZN7WebCore22RuntimeEnabledFeatures40isLangAttributeAwareFormControlUIEnabledE
  • trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

    r150356 r150663  
    6821968219                                </File>
    6822068220                                <File
    68221                                         RelativePath="..\bindings\js\JSDOMWindowWebAudioCustom.cpp"
    68222                                         >
    68223                                         <FileConfiguration
    68224                                                 Name="Debug|Win32"
    68225                                                 ExcludedFromBuild="true"
    68226                                                 >
    68227                                                 <Tool
    68228                                                         Name="VCCLCompilerTool"
    68229                                                 />
    68230                                         </FileConfiguration>
    68231                                         <FileConfiguration
    68232                                                 Name="Release|Win32"
    68233                                                 ExcludedFromBuild="true"
    68234                                                 >
    68235                                                 <Tool
    68236                                                         Name="VCCLCompilerTool"
    68237                                                 />
    68238                                         </FileConfiguration>
    68239                                         <FileConfiguration
    68240                                                 Name="Debug_Cairo_CFLite|Win32"
    68241                                                 ExcludedFromBuild="true"
    68242                                                 >
    68243                                                 <Tool
    68244                                                         Name="VCCLCompilerTool"
    68245                                                 />
    68246                                         </FileConfiguration>
    68247                                         <FileConfiguration
    68248                                                 Name="Release_Cairo_CFLite|Win32"
    68249                                                 ExcludedFromBuild="true"
    68250                                                 >
    68251                                                 <Tool
    68252                                                         Name="VCCLCompilerTool"
    68253                                                 />
    68254                                         </FileConfiguration>
    68255                                         <FileConfiguration
    68256                                                 Name="Debug_All|Win32"
    68257                                                 ExcludedFromBuild="true"
    68258                                                 >
    68259                                                 <Tool
    68260                                                         Name="VCCLCompilerTool"
    68261                                                 />
    68262                                         </FileConfiguration>
    68263                                         <FileConfiguration
    68264                                                 Name="Production|Win32"
    68265                                                 ExcludedFromBuild="true"
    68266                                                 >
    68267                                                 <Tool
    68268                                                         Name="VCCLCompilerTool"
    68269                                                 />
    68270                                         </FileConfiguration>
    68271                                 </File>
    68272                                 <File
    6827368221                                        RelativePath="..\bindings\js\JSDOMWrapper.cpp"
    6827468222                                        >
  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

    r150356 r150663  
    94219421    </ClCompile>
    94229422    <ClCompile Include="..\bindings\js\JSDOMWindowShell.cpp">
    9423       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
    9424       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</ExcludedFromBuild>
    9425       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
    9426       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
    9427       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</ExcludedFromBuild>
    9428       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
    9429     </ClCompile>
    9430     <ClCompile Include="..\bindings\js\JSDOMWindowWebAudioCustom.cpp">
    94319423      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
    94329424      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</ExcludedFromBuild>
  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters

    r150356 r150663  
    53385338      <Filter>bindings\js</Filter>
    53395339    </ClCompile>
    5340     <ClCompile Include="..\bindings\js\JSDOMWindowWebAudioCustom.cpp">
    5341       <Filter>bindings\js</Filter>
    5342     </ClCompile>
    53435340    <ClCompile Include="..\bindings\js\JSDOMWrapper.cpp">
    53445341      <Filter>bindings\js</Filter>
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r150652 r150663  
    34903490                A7F5D9501384F02D00A29A87 /* NodeRenderingContext.h in Headers */ = {isa = PBXBuildFile; fileRef = A7F5D94E1384F02D00A29A87 /* NodeRenderingContext.h */; };
    34913491                A80A38FE0E50CC8200A25EBC /* PatternCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A80A38FD0E50CC8200A25EBC /* PatternCG.cpp */; };
    3492                 A80A9423149F225E00989291 /* JSDOMWindowWebAudioCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A80A9422149F225E00989291 /* JSDOMWindowWebAudioCustom.cpp */; };
    34933492                A80D67080E9E9DEB00E420F0 /* GraphicsContextPlatformPrivateCG.h in Headers */ = {isa = PBXBuildFile; fileRef = A80D67070E9E9DEB00E420F0 /* GraphicsContextPlatformPrivateCG.h */; };
    34943493                A80E6CE40A1989CA007FB8C5 /* CSSValueList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A80E6CBA0A1989CA007FB8C5 /* CSSValueList.cpp */; };
     
    99859984                A7F73EDA169AD7AA00CBAA4B /* DOMShadowRoot.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMShadowRoot.mm; sourceTree = "<group>"; };
    99869985                A80A38FD0E50CC8200A25EBC /* PatternCG.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PatternCG.cpp; sourceTree = "<group>"; };
    9987                 A80A9422149F225E00989291 /* JSDOMWindowWebAudioCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMWindowWebAudioCustom.cpp; sourceTree = "<group>"; };
    99889986                A80D67070E9E9DEB00E420F0 /* GraphicsContextPlatformPrivateCG.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GraphicsContextPlatformPrivateCG.h; sourceTree = "<group>"; };
    99899987                A80E6CBA0A1989CA007FB8C5 /* CSSValueList.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = CSSValueList.cpp; sourceTree = "<group>"; };
     
    1887018868                                BCD9C25E0C17AA67005C90A2 /* JSDOMWindowCustom.cpp */,
    1887118869                                652FBBBB0DE27CB60001D386 /* JSDOMWindowCustom.h */,
    18872                                 A80A9422149F225E00989291 /* JSDOMWindowWebAudioCustom.cpp */,
    1887318870                                BC2ED5540C6B9BD300920BFF /* JSElementCustom.cpp */,
    1887418871                                BCEFAF4D0C317E6900FA81F6 /* JSEventCustom.cpp */,
     
    2550125498                                BCD9C2620C17AA67005C90A2 /* JSDOMWindowCustom.cpp in Sources */,
    2550225499                                BCBFB53C0DCD29CF0019B3E5 /* JSDOMWindowShell.cpp in Sources */,
    25503                                 A80A9423149F225E00989291 /* JSDOMWindowWebAudioCustom.cpp in Sources */,
    2550425500                                CDDE691F171DFAD000A44D89 /* JSAudioBufferCustom.cpp in Sources */,
    2550525501                                FD7868B9136B999200D403DF /* JSDynamicsCompressorNode.cpp in Sources */,
  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r148731 r150663  
    146146
    147147#if ENABLE(WEB_AUDIO)
    148     static void setWebkitAudioContextEnabled(bool isEnabled) { isWebAudioEnabled = isEnabled; }
     148    static void setWebAudioEnabled(bool isEnabled) { isWebAudioEnabled = isEnabled; }
    149149    static bool webkitAudioContextEnabled() { return isWebAudioEnabled; }
    150150    static bool webkitOfflineAudioContextEnabled() { return isWebAudioEnabled; }
  • trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp

    r150276 r150663  
    7070#include "JSDOMWindowCustom.cpp"
    7171#include "JSDOMWindowShell.cpp"
    72 #include "JSDOMWindowWebAudioCustom.cpp"
    7372#include "JSDOMWrapper.cpp"
    7473#include "JSDataViewCustom.cpp"
  • trunk/Source/WebCore/page/DOMWindow.idl

    r150509 r150663  
    336336    [Conditional=INDEXED_DATABASE] attribute IDBRequestConstructor webkitIDBRequest;
    337337    [Conditional=INDEXED_DATABASE] attribute IDBTransactionConstructor webkitIDBTransaction;
    338 
    339     // Constructors whose name does not match the interface name.
    340     [Conditional=WEB_AUDIO, CustomGetter] attribute AudioContextConstructor webkitAudioContext;
    341 
    342338#endif // defined(LANGUAGE_JAVASCRIPT)
    343339};
  • trunk/Source/WebCore/page/Settings.in

    r149340 r150663  
    116116antialiased2dCanvasEnabled initial=true
    117117loadDeferringEnabled initial=true
    118 webAudioEnabled initial=false
    119118paginateDuringLayoutEnabled initial=false
    120119fullScreenEnabled initial=false, conditional=FULLSCREEN_API
  • trunk/Source/WebKit/efl/ChangeLog

    r150353 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
     11        (DumpRenderTreeSupportEfl::setWebAudioEnabled):
     12        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
     13        * ewk/ewk_view.cpp:
     14        (_Ewk_View_Private_Data):
     15        (_ewk_view_priv_new):
     16        * ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer
     17        a view specific feature.
     18
    1192013-05-19  Anders Carlsson  <andersca@apple.com>
    220
  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp

    r150140 r150663  
    325325}
    326326
     327void DumpRenderTreeSupportEfl::setWebAudioEnabled(bool enabled)
     328{
     329#if ENABLE(WEB_AUDIO)
     330    WebCore::RuntimeEnabledFeatures::setWebAudioEnabled(enabled);
     331#else
     332    UNUSED_PARAM(enabled);
     333#endif
     334}
     335
    327336bool DumpRenderTreeSupportEfl::isCommandEnabled(const Evas_Object* ewkView, const char* name)
    328337{
  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h

    r145849 r150663  
    8282    static void setCSSRegionsEnabled(const Evas_Object* ewkView, bool enabled);
    8383    static void setSeamlessIFramesEnabled(bool);
     84    static void setWebAudioEnabled(bool);
    8485
    8586    static void forceLayout(Evas_Object* ewkFrame);
  • trunk/Source/WebKit/efl/ewk/ewk_view.cpp

    r150241 r150663  
    343343        bool pageCache : 1;
    344344        bool enableXSSAuditor : 1;
    345 #if ENABLE(WEB_AUDIO)
    346         bool webAudio : 1;
    347 #endif
    348345        bool webGLEnabled : 1;
    349346        bool tabsToLinks : 1;
     
    845842    priv->pageSettings->setUsesEncodingDetector(false);
    846843#if ENABLE(WEB_AUDIO)
    847     priv->pageSettings->setWebAudioEnabled(false);
     844    WebCore::RuntimeEnabledFeatures::setWebAudioEnabled(false);
    848845#endif
    849846    priv->pageSettings->setWebGLEnabled(true);
     
    921918
    922919    priv->settings.userAgent = ewk_settings_default_user_agent_get();
    923 #if ENABLE(WEB_AUDIO)
    924     priv->settings.webAudio = priv->pageSettings->webAudioEnabled();
    925 #endif
    926920
    927921    // Since there's no scale separated from zooming in webkit-efl, this functionality of
     
    46824676#endif
    46834677
    4684 Eina_Bool ewk_view_setting_web_audio_get(const Evas_Object* ewkView)
    4685 {
    4686 #if ENABLE(WEB_AUDIO)
    4687     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
    4688     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
    4689     return priv->settings.webAudio;
    4690 #else
    4691     UNUSED_PARAM(ewkView);
    4692     return false;
    4693 #endif
    4694 }
    4695 
    4696 Eina_Bool ewk_view_setting_web_audio_set(Evas_Object* ewkView, Eina_Bool enable)
    4697 {
    4698 #if ENABLE(WEB_AUDIO)
    4699     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
    4700     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
    4701     if (priv->settings.webAudio != enable) {
    4702         priv->pageSettings->setWebAudioEnabled(enable);
    4703         priv->settings.webAudio = enable;
    4704     }
    4705     return true;
    4706 #else
    4707     UNUSED_PARAM(ewkView);
    4708     UNUSED_PARAM(enable);
    4709     return false;
    4710 #endif
    4711 }
    4712 
    47134678void ewk_view_cursor_set(Evas_Object* ewkView, const WebCore::Cursor& cursor)
    47144679{
  • trunk/Source/WebKit/efl/ewk/ewk_view.h

    r150241 r150663  
    26862686
    26872687/**
    2688  * Queries if the web audio feature of HTML5 is enabled.
    2689  *
    2690  * @param o view object to query if the web audio feature is enabled
    2691  *
    2692  * @return @c EINA_TRUE if web audio is enabled,
    2693  *         @c EINA_FALSE if not or on failure
    2694  */
    2695 EAPI Eina_Bool    ewk_view_setting_web_audio_get(const Evas_Object *o);
    2696 
    2697 /**
    2698  * Enables/disables the web audio feature of HTML5.
    2699  *
    2700  * @param o view object to set the web audio
    2701  * @param enable @c EINA_TRUE to enable the web audio feature,
    2702  *        @c EINA_FALSE to disable
    2703  *
    2704  * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
    2705  */
    2706 EAPI Eina_Bool    ewk_view_setting_web_audio_set(Evas_Object *o, Eina_Bool enable);
    2707 
    2708 /**
    27092688 * Show the inspector to debug a web page.
    27102689 *
  • trunk/Source/WebKit/gtk/ChangeLog

    r150353 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
     9
     10        * webkit/webkitwebview.cpp:
     11        (webkit_web_view_update_settings):
     12        (webkit_web_view_settings_notify):
     13
    1142013-05-19  Anders Carlsson  <andersca@apple.com>
    215
  • trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp

    r150353 r150663  
    35733573
    35743574#if ENABLE(WEB_AUDIO)
    3575     coreSettings->setWebAudioEnabled(settingsPrivate->enableWebAudio);
     3575    WebCore::RuntimeEnabledFeatures::setWebAudioEnabled(settingsPrivate->enableWebAudio);
    35763576#endif
    35773577
     
    37193719#if ENABLE(WEB_AUDIO)
    37203720    else if (name == g_intern_string("enable-webaudio"))
    3721         settings->setWebAudioEnabled(g_value_get_boolean(&value));
     3721        RuntimeEnabledFeatures::setWebAudioEnabled(g_value_get_boolean(&value));
    37223722#endif
    37233723
  • trunk/Source/WebKit/mac/ChangeLog

    r150609 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
     9
     10        * WebView/WebView.mm:
     11        (-[WebView _preferencesChanged:]):
     12
    1132013-05-23  Anders Carlsson  <andersca@apple.com>
    214
  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r150205 r150663  
    14961496    settings->setShowDebugBorders([preferences showDebugBorders]);
    14971497    settings->setShowRepaintCounter([preferences showRepaintCounter]);
    1498     settings->setWebAudioEnabled([preferences webAudioEnabled]);
    14991498    settings->setWebGLEnabled([preferences webGLEnabled]);
    15001499    settings->setAccelerated2dCanvasEnabled([preferences accelerated2dCanvasEnabled]);
     
    15081507    RuntimeEnabledFeatures::setCSSRegionsEnabled([preferences cssRegionsEnabled]);
    15091508    RuntimeEnabledFeatures::setCSSCompositingEnabled([preferences cssCompositingEnabled]);
     1509#if ENABLE(WEB_AUDIO)
     1510    RuntimeEnabledFeatures::setWebAudioEnabled([preferences webAudioEnabled]);
     1511#endif
    15101512#if ENABLE(IFRAME_SEAMLESS)
    15111513    RuntimeEnabledFeatures::setSeamlessIFramesEnabled([preferences seamlessIFramesEnabled]);
  • trunk/Source/WebKit/qt/Api/qwebsettings.cpp

    r148951 r150663  
    176176#if ENABLE(WEB_AUDIO)
    177177        value = attributes.value(QWebSettings::WebAudioEnabled, global->attributes.value(QWebSettings::WebAudioEnabled));
    178         settings->setWebAudioEnabled(value);
     178        WebCore::RuntimeEnabledFeatures::setWebAudioEnabled(value);
    179179#endif
    180180
  • trunk/Source/WebKit/qt/ChangeLog

    r150353 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
     9
     10        * Api/qwebsettings.cpp:
     11        (QWebSettingsPrivate::apply):
     12
    1132013-05-19  Anders Carlsson  <andersca@apple.com>
    214
  • trunk/Source/WebKit/win/ChangeLog

    r150660 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
     9
     10        * WebView.cpp:
     11        (WebView::notifyPreferencesChanged):
     12
    1132013-05-24  Anders Carlsson  <andersca@apple.com>
    214
  • trunk/Source/WebKit/win/WebView.cpp

    r150353 r150663  
    49104910
    49114911#if ENABLE(WEB_AUDIO)
    4912     settings->setWebAudioEnabled(true);
     4912    RuntimeEnabledFeatures::setWebAudioEnabled(true);
    49134913#endif // ENABLE(WEB_AUDIO)
    49144914
  • trunk/Source/WebKit2/ChangeLog

    r150653 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.
     9
     10        * WebProcess/InjectedBundle/InjectedBundle.cpp:
     11        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
     12        * WebProcess/WebPage/WebPage.cpp:
     13        (WebKit::WebPage::updatePreferences):
     14
    1152013-05-24  Thomas Deniau  <deniau@apple.com>
    216
  • trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

    r150537 r150663  
    207207#endif
    208208
     209#if ENABLE(WEB_AUDIO)
     210    if (preference == "WebKitWebAudioEnabled")
     211        RuntimeEnabledFeatures::setWebAudioEnabled(enabled);
     212#endif
     213
    209214    // Map the names used in LayoutTests with the names used in WebCore::Settings and WebPreferencesStore.
    210215#define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
     
    221226    macro(WebKitPluginsEnabled, PluginsEnabled, pluginsEnabled) \
    222227    macro(WebKitUsesPageCachePreferenceKey, UsesPageCache, usesPageCache) \
    223     macro(WebKitWebAudioEnabled, WebAudioEnabled, webAudioEnabled) \
    224228    macro(WebKitWebGLEnabled, WebGLEnabled, webGLEnabled) \
    225229    macro(WebKitXSSAuditorEnabled, XSSAuditorEnabled, xssAuditorEnabled) \
  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r150521 r150663  
    24902490
    24912491#if ENABLE(WEB_AUDIO)
    2492     settings->setWebAudioEnabled(store.getBoolValueForKey(WebPreferencesKey::webAudioEnabledKey()));
     2492    RuntimeEnabledFeatures::setWebAudioEnabled(store.getBoolValueForKey(WebPreferencesKey::webAudioEnabledKey()));
    24932493#endif
    24942494
  • trunk/Tools/ChangeLog

    r150662 r150663  
     12013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
     2
     3        Remove custom code for webkitAudioContext global constructor getter
     4        https://bugs.webkit.org/show_bug.cgi?id=116530
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
     9        WebAudio feature instead of public ewk_view API since that API was
     10        removed.
     11
     12        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
     13        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
     14        * DumpRenderTree/efl/TestRunnerEfl.cpp:
     15        (TestRunner::overridePreference):
     16
    1172013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
    218
  • trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

    r149087 r150663  
    285285    ewk_view_setting_include_links_in_focus_chain_set(mainView(), EINA_FALSE);
    286286    ewk_view_setting_scripts_can_access_clipboard_set(mainView(), EINA_TRUE);
    287     ewk_view_setting_web_audio_set(mainView(), EINA_FALSE);
    288287    ewk_view_setting_allow_universal_access_from_file_urls_set(mainView(), EINA_TRUE);
    289288    ewk_view_setting_allow_file_access_from_file_urls_set(mainView(), EINA_TRUE);
     
    326325    DumpRenderTreeSupportEfl::setTracksRepaints(mainFrame(), false);
    327326    DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled(true);
     327    DumpRenderTreeSupportEfl::setWebAudioEnabled(false);
    328328
    329329    // Reset capacities for the memory cache for dead objects.
  • trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp

    r149659 r150663  
    662662        DumpRenderTreeSupportEfl::setCSSRegionsEnabled(browser->mainView(), toBool(value));
    663663    else if (equals(key, "WebKitWebAudioEnabled"))
    664         ewk_view_setting_web_audio_set(browser->mainView(), toBool(value));
     664        DumpRenderTreeSupportEfl::setWebAudioEnabled(toBool(value));
    665665    else if (equals(key, "WebKitDisplayImagesKey"))
    666666        ewk_view_setting_auto_load_images_set(browser->mainView(), toBool(value));
Note: See TracChangeset for help on using the changeset viewer.