Changeset 150701 in webkit

Timestamp:

May 25, 2013 7:57:51 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Teach webkitbot and WKR how to respond to yt?
​https://bugs.webkit.org/show_bug.cgi?id=116775

Reviewed by Andreas Kling.

• Scripts/webkitpy/tool/bot/irc_command.py:

(Hi): Fixed the usage string.
(Hi.execute): Made it more generic so that it works in WKR.
(YouThere): Added.
(YouThere.execute): Added.

• Scripts/webkitpy/tool/commands/newcommitbot.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/irc_command.py (modified) (3 diffs)
• Scripts/webkitpy/tool/commands/newcommitbot.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Teach webkitbot and WKR how to respond to yt?
+        https://bugs.webkit.org/show_bug.cgi?id=116775
+
+        Reviewed by Andreas Kling.
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        (Hi): Fixed the usage string.
+        (Hi.execute): Made it more generic so that it works in WKR.
+        (YouThere): Added.
+        (YouThere.execute): Added.
+        * Scripts/webkitpy/tool/commands/newcommitbot.py:
+
 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py

@@ -112 +112 @@
 class Hi(IRCCommand):
     usage_string = "hi"
-    help_string = "Retrieves a random quip from Bugzilla."
-
-    def execute(self, nick, args, tool, sheriff):
-        if len(args) and re.match(r'webkitbot_*\s*!\s*', ' '.join(args)):
+    help_string = "Responds with hi."
+
+    def execute(self, nick, args, tool, sheriff):
+        if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
             return "%s: hi %s!" % (nick, nick)
         quips = tool.bugs.quips()
@@ -128 +128 @@
     def execute(self, nick, args, tool, sheriff):
         return nick + ": pong"
+
+
+class YouThere(IRCCommand):
+    usage_string = "yt?"
+    help_string = "Responds with yes."
+
+    def execute(self, nick, args, tool, sheriff):
+        return "%s: yes" % nick
 
 
@@ -299 +307 @@
     "rollout": Rollout,
     "whois": Whois,
+    "yt?": YouThere,
 }
 

trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py

@@ -38 +38 @@
 from webkitpy.tool.bot.irc_command import PingPong
 from webkitpy.tool.bot.irc_command import Restart
+from webkitpy.tool.bot.irc_command import YouThere
 from webkitpy.tool.bot.ircbot import IRCBot
 from webkitpy.tool.commands.queues import AbstractQueue
@@ -53 +54 @@
         "ping": PingPong,
         "restart": Restart,
+        "yt?": YouThere,
     }