Changeset 150748 in webkit

Timestamp:

May 27, 2013 5:23:13 AM (11 years ago)

Author:

rgabor@webkit.org

Message:

MacroAssemblerARM should use xor to swap registers instead of move
​https://bugs.webkit.org/show_bug.cgi?id=116306

Reviewed by Zoltan Herczeg.

Change register swapping to xor from move and this way we don't need
temporary register anymore.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::swap):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerARM.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-05-27  Gabor Rapcsanyi  <rgabor@webkit.org>
+
+        MacroAssemblerARM should use xor to swap registers instead of move
+        https://bugs.webkit.org/show_bug.cgi?id=116306
+
+        Reviewed by Zoltan Herczeg.
+
+        Change register swapping to xor from move and this way we don't need
+        temporary register anymore.
+
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::swap):
+
 2013-05-25  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

@@ -540 +540 @@
     void swap(RegisterID reg1, RegisterID reg2)
     {
-        move(reg1, ARMRegisters::S0);
-        move(reg2, reg1);
-        move(ARMRegisters::S0, reg2);
+        xor32(reg1, reg2);
+        xor32(reg2, reg1);
+        xor32(reg1, reg2);
     }