Changeset 150827 in webkit


Ignore:
Timestamp:
May 28, 2013 1:17:47 PM (11 years ago)
Author:
jer.noble@apple.com
Message:

Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
https://bugs.webkit.org/show_bug.cgi?id=116882

Reviewed by Eric Carlson.

Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::repositionGenericCue):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r150820 r150827  
     12013-05-28  Jer Noble  <jer.noble@apple.com>
     2
     3        Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
     4        https://bugs.webkit.org/show_bug.cgi?id=116882
     5
     6        Reviewed by Eric Carlson.
     7
     8        Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.
     9
     10        * rendering/RenderTextTrackCue.cpp:
     11        (WebCore::RenderTextTrackCue::repositionGenericCue):
     12
    1132013-05-28  Alberto Garcia  <agarcia@igalia.com>
    214
  • trunk/Source/WebCore/rendering/RenderTextTrackCue.cpp

    r150453 r150827  
    323323{
    324324    ASSERT(firstChild());
    325     ASSERT(m_cue->cueType() == TextTrackCue::WebVTT);
    326325    InlineFlowBox* firstLineBox = toRenderInline(firstChild())->firstLineBox();
    327326    if (static_cast<TextTrackCueGeneric*>(m_cue)->useDefaultPosition() && firstLineBox) {
Note: See TracChangeset for help on using the changeset viewer.