Changeset 151000 in webkit

Timestamp:

May 30, 2013 6:52:47 PM (11 years ago)

Author:

barraclough@apple.com

Message:

fast/js/date-DST-time-cusps.html fails after ​http://trac.webkit.org/changeset/150833
​https://bugs.webkit.org/show_bug.cgi?id=116895
<rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
​https://bugs.webkit.org/show_bug.cgi?id=11157

Reviewed by Alexey Proskuryakov.

Accidental progression, updating results to expect success.

• TestExpectations:
  • Remove expectations of failure.
• fast/js/script-tests/date-DST-time-cusps.js:
  • Prefer the latter option for non-existent time (due to clock rolling forward).

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)
• fast/js/script-tests/date-DST-time-cusps.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-05-28  Gavin Barraclough  <barraclough@apple.com>
+
+        fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
+        https://bugs.webkit.org/show_bug.cgi?id=116895
+        <rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
+        https://bugs.webkit.org/show_bug.cgi?id=11157
+
+        Reviewed by Alexey Proskuryakov.
+
+        Accidental progression, updating results to expect success.
+
+        * TestExpectations:
+            - Remove expectations of failure.
+        * fast/js/script-tests/date-DST-time-cusps.js:
+            - Prefer the latter option for non-existent time (due to clock rolling forward).
+
 2013-05-30  Tim Horton  <timothy_horton@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -16 +16 @@
 # media/W3C/video/networkState/networkState_during_progress.html is flaky
 webkit.org/b/76280 media/W3C/video/networkState/networkState_during_progress.html [ Pass Failure ]
-
-# fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
-webkit.org/b/116895 fast/js/date-DST-time-cusps.html [ Failure ]

trunk/LayoutTests/fast/js/script-tests/date-DST-time-cusps.js

@@ -4 +4 @@
 
 description(
-"For times that shouldn't happen we currently go back an hour, but in reality we would like to go forward an hour.  This has been filed as a radar: 4777813"
-);
-
-description(
-"For times that happen twice the behavior of all major browsers seems to be to pick the second occurance, i.e. Standard Time not Daylight Time"
+"For times that happen twice the behavior of all major browsers seems to be to pick the second occurrance, i.e. Standard Time not Daylight Time"
 );
 
 var testCases = [];
 if ((new Date(2009, 9, 1)).toString().match("PDT")) {
-    testCases.push(["(new Date(1982, 2, 14, 2, 10)).getHours()", "1"]);
-    testCases.push(["(new Date(1982, 2, 14, 2)).getHours()", "1"]);
+    testCases.push(["(new Date(1982, 2, 14, 2, 10)).getHours()", "3"]);
+    testCases.push(["(new Date(1982, 2, 14, 2)).getHours()", "3"]);
     testCases.push(["(new Date(1982, 11, 7, 1, 10)).getTimezoneOffset()", "480"]);
     testCases.push(["(new Date(1982, 11, 7, 1)).getTimezoneOffset()", "480"]);