Changeset 151076 in webkit

Timestamp:

Jun 1, 2013 4:26:02 PM (11 years ago)

Author:

Darin Adler

Message:

window.speechSynthesis needs to be cheap
​https://bugs.webkit.org/show_bug.cgi?id=117111
rdar://problem/14042030

Reviewed by Dean Jackson.

Add the traditional laziness to all of the speech synthesis code, wherever
it was omitted.

• Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
(WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
platform speech synthesizer. Since this code is only used to set up a mock in the
test runner, the fact that it was wrong before was harmless, but still not good.
(WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
so we can get the voice list from it.
(WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
synthesizer here.
(WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
null and do nothing if it's not present.
(WebCore::SpeechSynthesis::pause): Ditto.
(WebCore::SpeechSynthesis::resume): Ditto.

• platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
when asked for a voice list.

• platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.

The unused setVoiceList function has been removed. The initializeVoiceList is now
private rather than protected. Added a new m_voiceListIsInitialized boolean.

• platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
m_voiceListIsInitialized to false.

• platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
stop when you destroy them.
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
call to m_voiceList.clear(), since the caller only calls this once when the
voice list is already clear.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/speech/SpeechSynthesis.cpp (modified) (7 diffs)
• platform/PlatformSpeechSynthesizer.cpp (modified) (1 diff)
• platform/PlatformSpeechSynthesizer.h (modified) (2 diffs)
• platform/mac/PlatformSpeechSynthesizerMac.mm (modified) (1 diff)
• platform/mock/PlatformSpeechSynthesizerMock.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-01  Darin Adler  <darin@apple.com>
+
+        window.speechSynthesis needs to be cheap
+        https://bugs.webkit.org/show_bug.cgi?id=117111
+        rdar://problem/14042030
+
+        Reviewed by Dean Jackson.
+
+        Add the traditional laziness to all of the speech synthesis code, wherever
+        it was omitted.
+
+        * Modules/speech/SpeechSynthesis.cpp:
+        (WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
+        (WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
+        (WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
+        platform speech synthesizer. Since this code is only used to set up a mock in the
+        test runner, the fact that it was wrong before was harmless, but still not good.
+        (WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
+        so we can get the voice list from it.
+        (WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
+        synthesizer here.
+        (WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
+        null and do nothing if it's not present.
+        (WebCore::SpeechSynthesis::pause): Ditto.
+        (WebCore::SpeechSynthesis::resume): Ditto.
+
+        * platform/PlatformSpeechSynthesizer.cpp:
+        (WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
+        to create a synthesizer.
+        (WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
+        when asked for a voice list.
+
+        * platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.
+        The unused setVoiceList function has been removed. The initializeVoiceList is now
+        private rather than protected. Added a new m_voiceListIsInitialized boolean.
+
+        * platform/mac/PlatformSpeechSynthesizerMac.mm:
+        (WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
+        m_voiceListIsInitialized to false.
+
+        * platform/mock/PlatformSpeechSynthesizerMock.cpp:
+        (WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
+        to create a synthesizer.
+        (WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
+        Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
+        stop when you destroy them.
+        (WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
+        call to m_voiceList.clear(), since the caller only calls this once when the
+        voice list is already clear.
+
 2013-06-01  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/Modules/speech/SpeechSynthesis.cpp

@@ -39 +39 @@
 PassRefPtr<SpeechSynthesis> SpeechSynthesis::create()
 {
-    return adoptRef(new SpeechSynthesis());
+    return adoptRef(new SpeechSynthesis);
 }
     
 SpeechSynthesis::SpeechSynthesis()
-    : m_platformSpeechSynthesizer(PlatformSpeechSynthesizer::create(this))
-    , m_currentSpeechUtterance(0)
+    : m_currentSpeechUtterance(0)
     , m_isPaused(false)
 {
@@ -52 +51 @@
 {
     m_platformSpeechSynthesizer = synthesizer;
+    m_voiceList.clear();
+    m_currentSpeechUtterance = 0;
+    m_utteranceQueue.clear();
+    m_isPaused = false;
 }
     
@@ -63 +66 @@
     if (m_voiceList.size())
         return m_voiceList;
-    
+
+    if (!m_platformSpeechSynthesizer)
+        m_platformSpeechSynthesizer = PlatformSpeechSynthesizer::create(this);
+
     // If the voiceList is empty, that's the cue to get the voices from the platform again.
     const Vector<RefPtr<PlatformSpeechSynthesisVoice> >& platformVoices = m_platformSpeechSynthesizer->voiceList();
@@ -98 +104 @@
     m_currentSpeechUtterance = utterance;
     m_isPaused = false;
+    if (!m_platformSpeechSynthesizer)
+        m_platformSpeechSynthesizer = PlatformSpeechSynthesizer::create(this);
     m_platformSpeechSynthesizer->speak(utterance->platformUtterance());
 }
@@ -119 +127 @@
     RefPtr<SpeechSynthesisUtterance> current = m_currentSpeechUtterance;
     m_utteranceQueue.clear();
-    m_platformSpeechSynthesizer->cancel();
+    if (m_platformSpeechSynthesizer)
+        m_platformSpeechSynthesizer->cancel();
     current = 0;
     
@@ -128 +137 @@
 void SpeechSynthesis::pause()
 {
-    if (!m_isPaused)
+    if (!m_isPaused && m_platformSpeechSynthesizer)
         m_platformSpeechSynthesizer->pause();
 }
@@ -134 +143 @@
 void SpeechSynthesis::resume()
 {
-    if (!m_currentSpeechUtterance)
-        return;
-    m_platformSpeechSynthesizer->resume();
+    if (m_currentSpeechUtterance && m_platformSpeechSynthesizer)
+        m_platformSpeechSynthesizer->resume();
 }
 

trunk/Source/WebCore/platform/PlatformSpeechSynthesizer.cpp

@@ -33 +33 @@
 PassOwnPtr<PlatformSpeechSynthesizer> PlatformSpeechSynthesizer::create(PlatformSpeechSynthesizerClient* client)
 {
-    OwnPtr<PlatformSpeechSynthesizer> synthesizer = adoptPtr(new PlatformSpeechSynthesizer(client));
-    synthesizer->initializeVoiceList();
-    return synthesizer.release();
+    return adoptPtr(new PlatformSpeechSynthesizer(client));
 }
 
-void PlatformSpeechSynthesizer::setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice> >& voices)
+const Vector<RefPtr<PlatformSpeechSynthesisVoice> >& PlatformSpeechSynthesizer::voiceList() const
 {
-    m_voiceList = voices;
+    if (!m_voiceListIsInitialized) {
+        ASSERT(m_voiceList.isEmpty());
+        const_cast<PlatformSpeechSynthesizer*>(this)->initializeVoiceList();
+        const_cast<PlatformSpeechSynthesizer*>(this)->m_voiceListIsInitialized = true;
+    }
+    return m_voiceList;
 }
-
 
 } // namespace WebCore

trunk/Source/WebCore/platform/PlatformSpeechSynthesizer.h

@@ -59 +59 @@
     virtual ~PlatformSpeechSynthesizerClient() { }
 };
-    
+
 class PlatformSpeechSynthesizer {
 public:
     static PassOwnPtr<PlatformSpeechSynthesizer> create(PlatformSpeechSynthesizerClient*);
 
+    // FIXME: We have multiple virtual functions just so we can support a mock for testing.
+    // Seems wasteful. Would be nice to find a better way.
     virtual ~PlatformSpeechSynthesizer();
     
-    const Vector<RefPtr<PlatformSpeechSynthesisVoice> >& voiceList() const { return m_voiceList; }
+    const Vector<RefPtr<PlatformSpeechSynthesisVoice> >& voiceList() const;
     virtual void speak(PassRefPtr<PlatformSpeechSynthesisUtterance>);
     virtual void pause();
@@ -74 +76 @@
     PlatformSpeechSynthesizerClient* client() const { return m_speechSynthesizerClient; }
 
-    void setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice> >&);
+protected:
+    explicit PlatformSpeechSynthesizer(PlatformSpeechSynthesizerClient*);
 
-protected:
+    Vector<RefPtr<PlatformSpeechSynthesisVoice> > m_voiceList;
+
+private:
     virtual void initializeVoiceList();
-    explicit PlatformSpeechSynthesizer(PlatformSpeechSynthesizerClient*);
-    Vector<RefPtr<PlatformSpeechSynthesisVoice> > m_voiceList;
-    
-private:
+
+    bool m_voiceListIsInitialized;
     PlatformSpeechSynthesizerClient* m_speechSynthesizerClient;
     

trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm

@@ -202 +202 @@
 
 PlatformSpeechSynthesizer::PlatformSpeechSynthesizer(PlatformSpeechSynthesizerClient* client)
-    : m_speechSynthesizerClient(client)
+    : m_voiceListIsInitialized(false)
+    , m_speechSynthesizerClient(client)
 {
 }

trunk/Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.cpp

@@ -34 +34 @@
 PassOwnPtr<PlatformSpeechSynthesizerMock> PlatformSpeechSynthesizerMock::create(PlatformSpeechSynthesizerClient* client)
 {
-    OwnPtr<PlatformSpeechSynthesizerMock> synthesizer = adoptPtr(new PlatformSpeechSynthesizerMock(client));
-    synthesizer->initializeVoiceList();
-    return synthesizer.release();
+    return adoptPtr(new PlatformSpeechSynthesizerMock(client));
 }
     
@@ -47 +45 @@
 PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock()
 {
-    m_speakingFinishedTimer.stop();
 }
 
@@ -59 +56 @@
 void PlatformSpeechSynthesizerMock::initializeVoiceList()
 {
-    m_voiceList.clear();
     m_voiceList.append(PlatformSpeechSynthesisVoice::create(String("mock.voice.bruce"), String("bruce"), String("en-US"), true, true));
     m_voiceList.append(PlatformSpeechSynthesisVoice::create(String("mock.voice.clark"), String("clark"), String("en-US"), true, false));
@@ -99 +95 @@
 }
 
-    
 } // namespace WebCore