Changeset 151079 in webkit


Ignore:
Timestamp:
Jun 1, 2013 9:42:57 PM (11 years ago)
Author:
Chris Fleizach
Message:

WebKit ignores aria-hidden when traversing nodes for name calculation
https://bugs.webkit.org/show_bug.cgi?id=117101

Reviewed by Tim Horton.

Source/WebCore:

When calculating the inner text, aria-hidden should be considered.

Test: accessibility/text-role-with-aria-hidden-inside.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):

LayoutTests:

  • accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
  • accessibility/text-role-with-aria-hidden-inside.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r151068 r151079  
     12013-06-01  Chris Fleizach  <cfleizach@apple.com>
     2
     3        WebKit ignores aria-hidden when traversing nodes for name calculation
     4        https://bugs.webkit.org/show_bug.cgi?id=117101
     5
     6        Reviewed by Tim Horton.
     7
     8        * accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
     9        * accessibility/text-role-with-aria-hidden-inside.html: Added.
     10
    1112013-05-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r151076 r151079  
     12013-06-01  Chris Fleizach  <cfleizach@apple.com>
     2
     3        WebKit ignores aria-hidden when traversing nodes for name calculation
     4        https://bugs.webkit.org/show_bug.cgi?id=117101
     5
     6        Reviewed by Tim Horton.
     7
     8        When calculating the inner text, aria-hidden should be considered.
     9
     10        Test: accessibility/text-role-with-aria-hidden-inside.html
     11
     12        * accessibility/AccessibilityNodeObject.cpp:
     13        (WebCore::shouldUseAccessiblityObjectInnerText):
     14
    1152013-06-01  Darin Adler  <darin@apple.com>
    216
  • trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

    r150796 r151079  
    14981498    // containers with lots of children.
    14991499
     1500    if (equalIgnoringCase(obj->getAttribute(aria_hiddenAttr), "true"))
     1501        return false;
     1502   
    15001503    // If something doesn't expose any children, then we can always take the inner text content.
    15011504    // This is what we want when someone puts an <a> inside a <button> for example.
Note: See TracChangeset for help on using the changeset viewer.