Changeset 151430 in webkit

Timestamp:

Jun 11, 2013 1:48:10 AM (11 years ago)

Author:

mihnea@adobe.com

Message:

[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
​https://bugs.webkit.org/show_bug.cgi?id=117295

Reviewed by Alexandru Chiculita.

Both test specify margins auto, which means that they can be computed to floats.
I changed the tests so that the margins are computed to integer values, to avoid
possible differences on platforms that enable subpixel layout.

• fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html:
• fast/regions/overflow-size-change-with-stacking-context-rtl.html:
• platform/qt/TestExpectations: Unskip the skipped test

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html (modified) (2 diffs)
• fast/regions/overflow-size-change-with-stacking-context-rtl.html (modified) (2 diffs)
• platform/qt/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-11  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
+        https://bugs.webkit.org/show_bug.cgi?id=117295
+
+        Reviewed by Alexandru Chiculita.
+
+        Both test specify margins auto, which means that they can be computed to floats.
+        I changed the tests so that the margins are computed to integer values, to avoid
+        possible differences on platforms that enable subpixel layout.
+
+        * fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html:
+        * fast/regions/overflow-size-change-with-stacking-context-rtl.html:
+        * platform/qt/TestExpectations: Unskip the skipped test
+
 2013-06-11  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html

@@ -26 +26 @@
 
             #region1 {
-                width: 200px;
+                width: 204px;
                 height: 100px;
             }
@@ -36 +36 @@
 
             #region3 {
-                width: 120px;
+                width: 116px;
                 height: 120px;
             }

trunk/LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl.html

@@ -32 +32 @@
 
             #region1 {
-                width: 200px;
+                width: 204px;
                 height: 100px;
             }
@@ -42 +42 @@
 
             #region3 {
-                width: 120px;
+                width: 116px;
                 height: 120px;
             }

trunk/LayoutTests/platform/qt/TestExpectations

@@ -1468 +1468 @@
 # failing fast tests
 # ============================================================================= #
-
-# [Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
-# https://bugs.webkit.org/show_bug.cgi?id=117295
-fast/regions/overflow-size-change-with-stacking-context-rtl.html
 
 # [Qt] Two new test in fast/regions/ flaky after r151282