Changeset 151492 in webkit

Timestamp:

Jun 12, 2013 1:51:48 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
​https://bugs.webkit.org/show_bug.cgi?id=116723

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

• GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the

current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.

Tools:

• TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,

remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.

Location:

trunk

Files:

• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/GNUmakefile.am (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/GNUmakefile.am (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
+        https://bugs.webkit.org/show_bug.cgi?id=116723
+
+        Reviewed by Carlos Garcia Campos.
+
+        * GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
+        current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
+        to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
+        and produces a working archive without problems even on incremental builds.
+
 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/GNUmakefile.am

@@ -586 +586 @@
 WebCoreLayerGtk2.a: $(webcore_layer_gtk2_deps)
         $(AM_V_GEN)
+        $(AM_V_at)$(shell rm -f $@)
         $(AM_V_at)$(foreach archive, $(webcore_layer_gtk2_archives), $(shell ar t $(archive) | xargs -n50 ar cruT $@))
 

trunk/Tools/ChangeLog

@@ +1 @@
+2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
+        https://bugs.webkit.org/show_bug.cgi?id=116723
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
+        remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
+        and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
+        not expensive and produces a working archive without problems even on incremental builds.
+
 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
 

trunk/Tools/TestWebKitAPI/GNUmakefile.am

@@ -122 +122 @@
 WebCoreLayer.a: $(webcore_layer_deps)
         $(AM_V_GEN)
+        $(AM_V_at)$(shell rm -f $@)
         $(AM_V_at)$(foreach archive, $(webcore_layer_archives), $(shell ar t $(archive) | xargs -n50 ar cruT $@))