Changeset 151550 in webkit

Timestamp:

Jun 13, 2013 9:12:51 AM (11 years ago)

Author:

Christophe Dumez

Message:

Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings
​https://bugs.webkit.org/show_bug.cgi?id=117593

Reviewed by Geoffrey Garen.

Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
when we already know the value is a int32 / uint32.

No new tests, no behavior change.

• bindings/js/JSDOMBinding.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSDOMBinding.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings
+        https://bugs.webkit.org/show_bug.cgi?id=117593
+
+        Reviewed by Geoffrey Garen.
+
+        Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
+        calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
+        when we already know the value is a int32 / uint32.
+
+        No new tests, no behavior change.
+
+        * bindings/js/JSDOMBinding.cpp:
+
 2013-06-13  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
 

trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp

@@ -310 +310 @@
 {
     if (value.isInt32())
-        return value.toInt32(exec);
+        return value.asInt32();
 
     double x = value.toNumber(exec);
@@ -322 +322 @@
 {
     if (value.isUInt32())
-        return value.toUInt32(exec);
+        return value.asUInt32();
 
     double x = value.toNumber(exec);
@@ -334 +334 @@
 {
     if (value.isInt32())
-        return value.toInt32(exec);
+        return value.asInt32();
 
     double x = value.toNumber(exec);
@@ -353 +353 @@
 {
     if (value.isUInt32())
-        return value.toUInt32(exec);
+        return value.asUInt32();
 
     double x = value.toNumber(exec);