Changeset 151565 in webkit

Timestamp:

Jun 13, 2013 11:24:21 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.

Source/WebCore:

Adding krit's fix: actual blending values should be compared, not the sets.
​https://bugs.webkit.org/show_bug.cgi?id=117223

Patch by Mihai Tica <​mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-image-color-dynamic.html

• rendering/style/FillLayer.cpp:

(WebCore::FillLayer::operator==):

LayoutTests:

Adding test that sets background blend modes from script, after the page is loaded.
​https://bugs.webkit.org/show_bug.cgi?id=117223

Patch by Mihai Tica <​mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

• fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
• fast/repaint/background-blend-mode-image-color-dynamic.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic-expected.html (added)
• LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/FillLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-13  Mihai Tica  <mitica@adobe.com>
+
+        Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
+
+        Adding test that sets background blend modes from script, after the page is loaded.
+        https://bugs.webkit.org/show_bug.cgi?id=117223
+
+        Reviewed by Dirk Schulze.
+
+        * fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
+        * fast/repaint/background-blend-mode-image-color-dynamic.html: Added.
+
 2013-06-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-13  Mihai Tica  <mitica@adobe.com>
+
+        Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
+
+        Adding krit's fix: actual blending values should be compared, not the sets.
+        https://bugs.webkit.org/show_bug.cgi?id=117223
+
+        Reviewed by Dirk Schulze.
+
+        Test: css3/compositing/background-blend-mode-image-color-dynamic.html
+
+        * rendering/style/FillLayer.cpp:
+        (WebCore::FillLayer::operator==):
+
 2013-06-13  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/rendering/style/FillLayer.cpp

@@ -154 +154 @@
             && m_backgroundXOrigin == o.m_backgroundXOrigin && m_backgroundYOrigin == o.m_backgroundYOrigin
             && m_attachment == o.m_attachment && m_clip == o.m_clip && m_composite == o.m_composite
-            && m_blendModeSet == o.m_blendModeSet && m_origin == o.m_origin && m_repeatX == o.m_repeatX
+            && m_blendMode == o.m_blendMode && m_origin == o.m_origin && m_repeatX == o.m_repeatX
             && m_repeatY == o.m_repeatY && m_sizeType == o.m_sizeType && m_sizeLength == o.m_sizeLength
             && m_type == o.m_type && ((m_next && o.m_next) ? *m_next == *o.m_next : m_next == o.m_next);