Changeset 151571 in webkit

Timestamp:

Jun 13, 2013 3:32:50 PM (11 years ago)

Author:

mvujovic@adobe.com

Message:

[CSS Regions] Selection dragged from a region paints its background
​https://bugs.webkit.org/show_bug.cgi?id=117607

Reviewed by Alexandru Chiculita.

.:

Add a manual test for the painting of a dragged selection from a region. We don't have an
automated way to test this yet. This test is similar to the other manual selection dragging
tests (e.g. ManualTests/drag-image.html).

• ManualTests/regions/drag-selection-painting.html: Added.

Source/WebCore:

When a RenderFlowThread is in the selection paint phase, tell its layer to paint with the
selection only behavior. This way, only foregrounds and not backgrounds will be painted in
the dragged selection.

Manual test: ManualTests/regions/drag-selection-painting.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• ManualTests/regions (added)
• ManualTests/regions/drag-selection-painting.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFlowThread.cpp (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2013-06-13  Max Vujovic  <mvujovic@adobe.com>
+
+        [CSS Regions] Selection dragged from a region paints its background
+        https://bugs.webkit.org/show_bug.cgi?id=117607
+
+        Reviewed by Alexandru Chiculita.
+
+        Add a manual test for the painting of a dragged selection from a region. We don't have an
+        automated way to test this yet. This test is similar to the other manual selection dragging
+        tests (e.g. ManualTests/drag-image.html).
+
+        * ManualTests/regions/drag-selection-painting.html: Added.
+
 2013-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-13  Max Vujovic  <mvujovic@adobe.com>
+
+        [CSS Regions] Selection dragged from a region paints its background
+        https://bugs.webkit.org/show_bug.cgi?id=117607
+
+        Reviewed by Alexandru Chiculita.
+
+        When a RenderFlowThread is in the selection paint phase, tell its layer to paint with the
+        selection only behavior. This way, only foregrounds and not backgrounds will be painted in
+        the dragged selection.
+
+        Manual test: ManualTests/regions/drag-selection-painting.html
+
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
+
 2013-06-13  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -307 +307 @@
         if (info.phase == PaintPhaseTextClip)
             paintBehavior |= PaintBehaviorForceBlackText;
+        else if (info.phase == PaintPhaseSelection)
+            paintBehavior |= PaintBehaviorSelectionOnly;
 
         layer()->paint(context, info.rect, paintBehavior, 0, region, RenderLayer::PaintLayerTemporaryClipRects);