Changeset 151684 in webkit

Timestamp:

Jun 18, 2013 8:16:02 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

<video> element delays document load event for ~ 3 seconds
​https://bugs.webkit.org/show_bug.cgi?id=90272

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-06-18
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-preload-no-delay-loadevent.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
No need to delay document load event here when preload="none"

LayoutTests:

• media/media-preload-no-delay-loadevent-expected.txt: Added.
• media/media-preload-no-delay-loadevent.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/media-preload-no-delay-loadevent-expected.txt (added)
• LayoutTests/media/media-preload-no-delay-loadevent.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-18  Santosh Mahto  <santosh.ma@samsung.com>
+
+        <video> element delays document load event for ~ 3 seconds
+        https://bugs.webkit.org/show_bug.cgi?id=90272
+
+        Reviewed by Eric Carlson.
+
+        * media/media-preload-no-delay-loadevent-expected.txt: Added.
+        * media/media-preload-no-delay-loadevent.html: Added.
+
 2013-06-18  Gabor Abraham  <abrhm@inf.u-szeged.hu>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-18  Santosh Mahto  <santosh.ma@samsung.com>
+
+        <video> element delays document load event for ~ 3 seconds
+        https://bugs.webkit.org/show_bug.cgi?id=90272
+
+        Reviewed by Eric Carlson.
+
+        Test: media/media-preload-no-delay-loadevent.html
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::prepareForLoad):
+        No need to delay document load event here  when preload="none"
+
 2013-06-18  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -864 +864 @@
     // algorithm, but do it now because we won't start that until after the timer fires and the 
     // event may have already fired by then.
-    setShouldDelayLoadEvent(true);
+    if (m_preload != MediaPlayer::None)
+        setShouldDelayLoadEvent(true);
 
     configureMediaControls();