Changeset 151822 in webkit
- Timestamp:
- Jun 20, 2013 8:52:46 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r151821 r151822 1 2013-06-20 Ryosuke Niwa <rniwa@webkit.org> 2 3 REGRESSION(r145788): mouse drag on canvas shouldn't start selection 4 https://bugs.webkit.org/show_bug.cgi?id=117860 5 6 Reviewed by Benjamin Poulain. 7 8 Add a regression test for dragging mouse inside a canvas. 9 The canvas should not be selected and mouseup event should fire. 10 11 * fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added. 12 * fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added. 13 1 14 2013-06-20 Ryosuke Niwa <rniwa@webkit.org> 2 15 -
trunk/Source/WebCore/ChangeLog
r151821 r151822 1 2013-06-20 Ryosuke Niwa <rniwa@webkit.org> 2 3 REGRESSION(r145788): mouse drag on canvas shouldn't start selection 4 https://bugs.webkit.org/show_bug.cgi?id=117860 5 6 Reviewed by Benjamin Poulain. 7 8 Like HTMLImageElement, HTMLCanvasElement shouldn't start selection. 9 10 Also uninline some virtual function overrides. 11 12 Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html 13 14 * html/HTMLCanvasElement.cpp: 15 (WebCore::HTMLCanvasElement::areAuthorShadowsAllowed): 16 (WebCore::HTMLCanvasElement::canContainRangeEndPoint): 17 (WebCore::HTMLCanvasElement::canStartSelection): 18 * html/HTMLCanvasElement.h: 19 1 20 2013-06-20 Ryosuke Niwa <rniwa@webkit.org> 2 21 -
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
r151298 r151822 128 128 } 129 129 130 bool HTMLCanvasElement::areAuthorShadowsAllowed() const 131 { 132 return false; 133 } 134 135 bool HTMLCanvasElement::canContainRangeEndPoint() const 136 { 137 return false; 138 } 139 140 bool HTMLCanvasElement::canStartSelection() const 141 { 142 return false; 143 } 144 130 145 void HTMLCanvasElement::addObserver(CanvasObserver* observer) 131 146 { -
trunk/Source/WebCore/html/HTMLCanvasElement.h
r151298 r151822 143 143 float deviceScaleFactor() const { return m_deviceScaleFactor; } 144 144 145 virtual bool canContainRangeEndPoint() const { return false; }146 147 145 private: 148 146 HTMLCanvasElement(const QualifiedName&, Document*); … … 151 149 virtual RenderObject* createRenderer(RenderArena*, RenderStyle*); 152 150 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE; 153 virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; } 151 virtual bool areAuthorShadowsAllowed() const OVERRIDE; 152 153 virtual bool canContainRangeEndPoint() const OVERRIDE; 154 virtual bool canStartSelection() const OVERRIDE; 154 155 155 156 void reset();
Note: See TracChangeset
for help on using the changeset viewer.