Changeset 152132 in webkit

Timestamp:

Jun 27, 2013 3:40:32 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Unnecessary root layer commits occur during html5 video playback
​https://bugs.webkit.org/show_bug.cgi?id=118147

Patch by Andrew Lo <​anlo@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson, John Griggs.

Only request layer commits when layer properties change in
GraphicsLayerBlackBerry::updateContentsRect and
GraphicsLayerBlackBerry::setContentsToMedia.
JIRA112749.

• platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-27  Andrew Lo  <anlo@blackberry.com>
+
+        [BlackBerry] Unnecessary root layer commits occur during html5 video playback
+        https://bugs.webkit.org/show_bug.cgi?id=118147
+
+        Reviewed by Rob Buis.
+        Internally reviewed by Arvid Nilsson, John Griggs.
+
+        Only request layer commits when layer properties change in
+        GraphicsLayerBlackBerry::updateContentsRect and
+        GraphicsLayerBlackBerry::setContentsToMedia.
+        JIRA112749.
+
+        * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
+        (WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
+        (WebCore::GraphicsLayerBlackBerry::updateContentsRect):
+
 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
 

trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp

@@ -570 +570 @@
             childrenChanged = true;
         }
-        layer->setOwner(this);
-        layer->setNeedsDisplay();
+
+        if (layer->owner() != this) {
+            layer->setOwner(this);
+            layer->setNeedsDisplay();
+        }
         updateContentsRect();
     } else {
@@ -855 +858 @@
         return;
 
-    m_contentsLayer->setPosition(m_contentsRect.location());
-    m_contentsLayer->setBounds(m_contentsRect.size());
+    if (m_contentsLayer->position() != m_contentsRect.location())
+        m_contentsLayer->setPosition(m_contentsRect.location());
+
+    if (m_contentsLayer->bounds() != m_contentsRect.size())
+        m_contentsLayer->setBounds(m_contentsRect.size());
 }