Changeset 152150 in webkit


Ignore:
Timestamp:
Jun 27, 2013 7:28:21 PM (11 years ago)
Author:
kangil.han@samsung.com
Message:

HTMLAudioElement doesn't have to know about isVideo function
​https://bugs.webkit.org/show_bug.cgi?id=118116

Reviewed by Eric Carlson.

Minor code cleanup to remove isVideo function from HTMLAudioElement.
We can use default function in HTMLMediaElement as hasVideo does.

  • html/HTMLAudioElement.h:
  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::isVideo):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r152149 r152150  
     12013-06-27  Kangil Han  <kangil.han@samsung.com>
     2
     3        HTMLAudioElement doesn't have to know about isVideo function
     4        https://bugs.webkit.org/show_bug.cgi?id=118116
     5
     6        Reviewed by Eric Carlson.
     7
     8        Minor code cleanup to remove isVideo function from HTMLAudioElement.
     9        We can use default function in HTMLMediaElement as hasVideo does.
     10
     11        * html/HTMLAudioElement.h:
     12        * html/HTMLMediaElement.h:
     13        (WebCore::HTMLMediaElement::isVideo):
     14
    1152013-06-27  Kangil Han  <kangil.han@samsung.com>
    216

  • trunk/Source/WebCore/html/HTMLAudioElement.h

    r151981 r152150  
    4242private:
    4343    HTMLAudioElement(const QualifiedName&, Document*, bool);
    44 
    45     virtual bool isVideo() const { return false; }
    4644};
    4745

  • trunk/Source/WebCore/html/HTMLMediaElement.h

    r151958 r152150  
    102102    MediaPlayer* player() const { return m_player.get(); }
    103103
    104     virtual bool isVideo() const = 0;
     104    virtual bool isVideo() const { return false; }
    105105    virtual bool hasVideo() const { return false; }
    106106    virtual bool hasAudio() const;
Note: See TracChangeset for help on using the changeset viewer.