Changeset 152165 in webkit

Timestamp:

Jun 28, 2013 7:49:24 AM (11 years ago)

Author:

sergio@webkit.org

Message:

[WK2][GTK] 100% CPU usage rendering a page with animations
​https://bugs.webkit.org/show_bug.cgi?id=117703

Reviewed by Martin Robinson.

Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::flushAndRenderLayers):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-06-28  Sergio Villar Senin  <svillar@igalia.com>
+
+        [WK2][GTK] 100% CPU usage rendering a page with animations
+        https://bugs.webkit.org/show_bug.cgi?id=117703
+
+        Reviewed by Martin Robinson.
+
+        Unconditionally update the value of m_lastFlushTime in
+        ::flushAndRenderLayers. By doing that we avoid a neverending
+        sequence of layer flushes that happened when m_lastFlushTime==0
+        and flushPendingLayerChanges() was false. In that situation the
+        value m_lastFlushTime was never updated so a new flush was always
+        rescheduled.
+
+        * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
+        (WebKit::LayerTreeHostGtk::flushAndRenderLayers):
+
 2013-06-28  Andres Gomez  <agomez@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp

@@ -361 +361 @@
         return;
 
+    m_lastFlushTime = currentTime();
     if (!flushPendingLayerChanges())
         return;
 
-    m_lastFlushTime = currentTime();
     // Our model is very simple. We always composite and render the tree immediately after updating it.
     compositeLayersToContext();