Changeset 152178 in webkit

Timestamp:

Jun 28, 2013 11:00:53 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

SVG relayout problem when displayed with different image box heights
​https://bugs.webkit.org/show_bug.cgi?id=118140

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.

Source/WebCore:

If the root element is an SVG, its position and height are affected
by the view height.

Test: svg/as-image/same-source-different-height.html

• rendering/RenderView.cpp:

(WebCore::RenderView::layout):

LayoutTests:

• svg/as-image/same-source-different-height-expected.html: Added.
• svg/as-image/same-source-different-height.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/as-image/same-source-different-height-expected.html (added)
• LayoutTests/svg/as-image/same-source-different-height.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-28  Morten Stenshorne  <mstensho@opera.com>
+
+        SVG relayout problem when displayed with different image box heights
+        https://bugs.webkit.org/show_bug.cgi?id=118140
+
+        Reviewed by Philip Rogers.
+
+        * svg/as-image/same-source-different-height-expected.html: Added.
+        * svg/as-image/same-source-different-height.html: Added.
+
 2013-06-28  Mario Sanchez Prada  <mario.prada@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-28  Morten Stenshorne  <mstensho@opera.com>
+
+        SVG relayout problem when displayed with different image box heights
+        https://bugs.webkit.org/show_bug.cgi?id=118140
+
+        Reviewed by Philip Rogers.
+
+        If the root element is an SVG, its position and height are affected
+        by the view height.
+
+        Test: svg/as-image/same-source-different-height.html
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::layout):
+
 2013-06-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -281 +281 @@
                     || child->style()->logicalHeight().isViewportPercentage()
                     || child->style()->logicalMinHeight().isViewportPercentage()
-                    || child->style()->logicalMaxHeight().isViewportPercentage())
+                    || child->style()->logicalMaxHeight().isViewportPercentage()
+#if ENABLE(SVG)
+                    || child->isSVGRoot()
+#endif
+                )
                 child->setChildNeedsLayout(true, MarkOnlyThis);
         }