Changeset 152195 in webkit

Timestamp:

Jun 28, 2013 4:40:09 PM (11 years ago)

Author:

aestes@apple.com

Message:

[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=118208

Reviewed by Mark Rowe.

Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.

Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.

• TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Configurations/Base.xcconfig (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-06-28  Andy Estes  <aestes@apple.com>
+
+        [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
+        https://bugs.webkit.org/show_bug.cgi?id=118208
+
+        Reviewed by Mark Rowe.
+
+        Newer versions of clang use a default template depth of 128, but this
+        is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
+        previous default.
+
+        Clang lowered the default to keep recursive template instantiation
+        from overflowing the stack (see <rdar://problem/13935016>), but
+        TestWebKitAPI's C++ files don't trigger a stack overflow even with the
+        higher limit. If for some reason this starts happening then we can
+        lower the limit back down.
+
+        * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
+
 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
 

trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig

@@ -44 +44 @@
 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
+OTHER_CPLUSPLUSFLAGS = $(OTHER_CPLUSPLUSFLAGS) -ftemplate-depth=256;
 
 // DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.