Changeset 152199 in webkit

Timestamp:

Jun 28, 2013 6:25:43 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
​https://bugs.webkit.org/show_bug.cgi?id=118122

Patch by James Craig <​james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.

Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by ​http://webkit.org/b/118162

• UserInterface/FilterBar.css:

(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):

• UserInterface/FilterBar.js:

(WebInspector.FilterBar):

• UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

• UserInterface/SearchBar.css:

(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):

• UserInterface/SearchBar.js:

(WebInspector.SearchBar):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/FilterBar.css (modified) (1 diff)
• UserInterface/FilterBar.js (modified) (1 diff)
• UserInterface/ResourceSidebarPanel.js (modified) (1 diff)
• UserInterface/SearchBar.css (modified) (1 diff)
• UserInterface/SearchBar.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2013-06-28  James Craig  <james@cookiecrook.com>
+
+        Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
+        https://bugs.webkit.org/show_bug.cgi?id=118122
+
+        Reviewed by Timothy Hatcher.
+
+        Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
+        so that screen readers will not indicate a bogus :required/:invalid state to the user.
+        Minor cosmetic difference blocked by http://webkit.org/b/118162
+
+        * UserInterface/FilterBar.css:
+        (.filter-bar > input[type="search"]:focus):
+        (.filter-bar > input[type="search"]:not(:placeholder-shown)):
+        * UserInterface/FilterBar.js:
+        (WebInspector.FilterBar):
+        * UserInterface/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel):
+        * UserInterface/SearchBar.css:
+        (.search-bar > input[type="search"]:focus):
+        (.search-bar > input[type="search"]:not(:placeholder-shown)):
+        * UserInterface/SearchBar.js:
+        (WebInspector.SearchBar):
+
 2013-06-27  James Craig  <james@cookiecrook.com>
 

trunk/Source/WebInspectorUI/UserInterface/FilterBar.css

@@ -58 +58 @@
 }
 
-.filter-bar > input[type="search"]:focus,
-.filter-bar > input[type="search"]:valid {
-    background-color: white;
-}
+.filter-bar > input[type="search"]:focus { background-color: white; }
+.filter-bar > input[type="search"]:not(:placeholder-shown) { background-color: white; } /* Needs to be a separate rule. See http://webkit.org/b/118162 */
 
 .filter-bar > input[type="search"]::-webkit-search-decoration {

trunk/Source/WebInspectorUI/UserInterface/FilterBar.js

@@ -32 +32 @@
     this._inputField = document.createElement("input");
     this._inputField.type = "search";
-    this._inputField.required = true;
     this._inputField.spellcheck = false;
     this._inputField.incremental = true;

trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js

@@ -33 +33 @@
     this._inputElement = document.createElement("input");
     this._inputElement.type = "search";
-    this._inputElement.required = true;
     this._inputElement.spellcheck = false;
     this._inputElement.addEventListener("search", this._searchFieldChanged.bind(this));

trunk/Source/WebInspectorUI/UserInterface/SearchBar.css

@@ -46 +46 @@
 }
 
-.search-bar > input[type="search"]:focus,
-.search-bar > input[type="search"]:valid {
-    background-color: white;
-}
+.search-bar > input[type="search"]:focus { background-color: white; }
+.search-bar > input[type="search"]:not(:placeholder-shown) { background-color: white; } /* Needs to be a separate rule. See http://webkit.org/b/118162 */

trunk/Source/WebInspectorUI/UserInterface/SearchBar.js

@@ -36 +36 @@
     this._searchInput = this._element.appendChild(document.createElement("input"));
     this._searchInput.type = "search";
-    this._searchInput.required = true;
     this._searchInput.spellcheck = false;
     this._searchInput.incremental = true;